1. Forum
  2. Usenet
  3. LINUX.DEBIAN.MAINT.BOOT

  • busybox: CONFIG_FEATURE_DI_ENV_HACK: is it still needed?

    From Michael Tokarev@21:1/5 to All on Sun Dec 31 17:20:01 2023
    Hi!

    There's a debian-specific patch in busybox since 2017 which adds ability
    to lift variable name filtering rules for d-i. A comment in there says:

    This is not a long term fix for this problem: a different approach is
    needed to parse the values from the kernel command-line, but we don't
    want to be responsible for holding up the debian-installer alpha
    release any longer than it has already.

    Is it still needed in 2024?

    Thanks,

    /mjt

    --- SoupGate-Win32 v1.05
    * Origin: fsxNet Usenet Gateway (21:1/5)
  • From Michael Tokarev@21:1/5 to Michael Tokarev on Tue Jun 25 21:00:01 2024
    31.12.2023 19:11, Michael Tokarev wrote:
    Hi!

    There's a debian-specific patch in busybox since 2017 which adds ability
    to lift variable name filtering rules for d-i.  A comment in there says:

        This is not a long term fix for this problem: a different approach is
        needed to parse the values from the kernel command-line, but we don't
        want to be responsible for holding up the debian-installer alpha
        release any longer than it has already.

    Is it still needed in 2024?

    A friendly ping?

    Thanks,

    /mjt

    --- SoupGate-Win32 v1.05
    * Origin: fsxNet Usenet Gateway (21:1/5)
  • From Cyril Brulebois@21:1/5 to All on Tue Jun 25 21:30:01 2024
    Michael Tokarev <mjt@tls.msk.ru> (2024-06-25):
    31.12.2023 19:11, Michael Tokarev wrote:
    Hi!

    There's a debian-specific patch in busybox since 2017 which adds ability
    to lift variable name filtering rules for d-i.  A comment in there says:

        This is not a long term fix for this problem: a different approach is
        needed to parse the values from the kernel command-line, but we don't
        want to be responsible for holding up the debian-installer alpha
        release any longer than it has already.

    Is it still needed in 2024?

    A friendly ping?

    I can't dive into it right now to be 100% sure, but I can't think of a
    reason why we wouldn't need to keep that. (I'm not aware of any work in
    that area, except some extra fun with hostname last year, but maybe
    someone worked on that without my noticing.)


    Cheers,
    --
    Cyril Brulebois (kibi@debian.org) <https://debamax.com/>
    D-I release manager -- Release team member -- Freelance Consultant

    -----BEGIN PGP SIGNATURE-----

    iQIzBAABCgAdFiEEtg6/KYRFPHDXTPR4/5FK8MKzVSAFAmZ7GOIACgkQ/5FK8MKz VSCL/g//dGVtIU10W+I4Dz06nH7uqLRokSLhDgW6vCDAUPEFC0FbGeyIJBuvos2J qI7AK0LAO4psLsniRfz/bupQ9jGc8vnsiMk/OtCS1+ZuSLsH50quGDInvT1l1//j We3Y8jqsSvEj+k9agvJRIg/MyQtK1qu9rKUkS2ioP+tWvnXH1pxKXkhXWI9q9maX A3KaMLgxv/g8ssdzxLf4FqXHhol+NEmNwNYxqB4s1PVG+Ut45kfFP9qIWl7UObk5 +bDFND946FVOKLzxZVKVfS74VY1EHb4YMJ0jebzPGoqKTnvHDfV4OBj0CDZKHJb9 oXPi1LA8+RAhQRUptM8zumxY4w7h6klBxs6eSftect57417JkhoAApZKdwxVTuRE AbDjapBh/EyMqn+4UpK3W+aiWB3CCmXZ3mCvC2GovBbtamCRflAtjQvJxYNZXkBB 24nfwSWAbawx9XjhxepmXWc1KumLrMMdmse3p1tqyKf6Ucwme4lNCj63iRjnDPde ESpIQYphOGT+ZzAq9v/S3mnc4ybloJ4WkeAFYdYmC47R5f2rhPYfYgEVpFncPFcI x0IdEM1PP7px2tjafIdLqNIICCFZkimw/KO9TnOmA0RdiErIZP+IqpIT/C69zPPZ I7JQprRK+A5MC+KcFQNkmP27Unw+ERI8U0aO4XXypoDN9SDpd2U=
    =GDrv
    -----END PGP SIGNATURE-----

    --- SoupGate-Win32 v1.05
    *
  • From Chris Boot@21:1/5 to Cyril Brulebois on Tue Jul 2 23:00:02 2024
    On 25/06/2024 20:22, Cyril Brulebois wrote:
    Michael Tokarev <mjt@tls.msk.ru> (2024-06-25):
    31.12.2023 19:11, Michael Tokarev wrote:
    Hi!

    There's a debian-specific patch in busybox since 2017 which adds ability >>> to lift variable name filtering rules for d-i.  A comment in there says: >>>
        This is not a long term fix for this problem: a different approach is
        needed to parse the values from the kernel command-line, but we don't
        want to be responsible for holding up the debian-installer alpha >>>     release any longer than it has already.

    Is it still needed in 2024?

    A friendly ping?

    I can't dive into it right now to be 100% sure, but I can't think of a
    reason why we wouldn't need to keep that. (I'm not aware of any work in
    that area, except some extra fun with hostname last year, but maybe
    someone worked on that without my noticing.)

    I remember adding that. From memory, it's because we pass arguments to
    d-i as kernel command-line args. Those get converted to environment
    variables by the kernel (I think?), which is how d-i picks them up.

    But those arguments have odd characters (for environment variables) in
    them, such as slashes. At some point busybox started filtering out such
    invalid environment variables, so d-i stopped seeing them. The hack is
    needed to avoid filtering them out.

    Before we can remove this hack, d-i would need to presumably parse /proc/cmdline itself to get its arguments, rather than simply assuming
    they would be in the environment. As far as I'm aware this hasn't been done.

    HTH,
    Chris

    --
    Chris Boot
    bootc@debian.org

    --- SoupGate-Win32 v1.05
    * Origin: fsxNet Usenet Gateway (21:1/5)