Thank you for your contribution to Debian.
Accepted:
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512
Format: 1.8
Date: Tue, 21 Jan 2025 22:20:55 +0100
Source: tzsetup
Architecture: source
Version: 1:0.126
Distribution: unstable
Urgency: medium
Maintainer: Debian Install System Team <debian-boot@lists.debian.org> Changed-By: Aurelien Jarno <aurel32@debian.org>
Closes: 1055541
Changes:
tzsetup (1:0.126) unstable; urgency=medium
.
* Team upload
.
[ Aurelien Jarno ]
* Replace legacy timezones with their modern counterparts. Closes: #1055541.
* Update cities/zones that have been renamed.
* Add templates for Cyprus.
.
[ Updated translations ]
* Persian (fa.po) by Danial Behzadi
* Romanian (ro.po) by Remus-Gabriel Chelu
Checksums-Sha1:
0f33102fa1f0556ecb587c46e11cdbfb0b864d3a 1652 tzsetup_0.126.dsc
285e7d63c6400e4d4172afde3027241660ce54aa 116072 tzsetup_0.126.tar.xz
88b2899e02fdc152d282abc42c5ace02c1950aea 5667 tzsetup_0.126_source.buildinfo Checksums-Sha256:
ead4e9585b879018ed56038b3ed966dca93364b871c4ff40689fa9e590003ca5 1652 tzsetup_0.126.dsc
6babea06332fceb2f65d52a7f502c3263c7f513bd45cb858d8063d20fafd5eb7 116072 tzsetup_0.126.tar.xz
845f5340f82f3da42ef92d541e7a35d773c6610b278b24a104d8a879e3cffae6 5667 tzsetup_0.126_source.buildinfo
Files:
07187e86344cebbabd8f584af8d3f53d 1652 debian-installer optional tzsetup_0.126.dsc
9e827b8db59218264b3a1c8817f0eb83 116072 debian-installer optional tzsetup_0.126.tar.xz
ca030b053683e1befbab579452fee185 5667 debian-installer optional tzsetup_0.126_source.buildinfo
-----BEGIN PGP SIGNATURE-----
iQIzBAEBCgAdFiEEUryGlb40+QrX1Ay4E4jA+JnoM2sFAmeQENcACgkQE4jA+Jno M2tR7hAAnfyZY1EMT3LC0UghMi3FrveuGtiNNOMGybL6rTr0skNFsiyRlLRczHFc +TG/LRx62I+GlnDImyMAtOKsJ0/wvTb1GQiSYoV1q5hopgk4b8ziwZQoepQAFSyH hyQb2GlLOjevQ3Bk0jAkWhYw8Aj02sxI0THGzQfQBaPN9wsA+Q+v3CRZTL8P+xUW G+FKSm3bTS+4f6SH8sh5WD0xL1IyJB9wG4C9kvB115nIvXwZWjZk5TKbZrMOaaMs 5N36KNoK0Af/4e13VBGCrVURbg79e+iZmrCNScHAezyGPtDMmAdVxXkCsLlN6mK8 u3E+dSyB9vPM8k8go4k5yaygvWACtccAElqPAhnp65h2l2CivEr6LwsBjZwbh83O 9bS2xQJh/5Vp4xwltIax3zy2nY8IcYKoTzi/LViX+JRIeF0aX4xCx4hTlDXqTAW9 Rlo/UB0FNAq/ZqIZ4thMpXJjUIyKyWdWn2ImoqmybEaDmd8PDaHa6UETkg6TBTqJ ZdpWD/fMzrf80gwYmOWPV1YcGaFjsfjNooWwct1kpoXDs7CQ0LurtZU2g7TH8lAX vNtAwVATXbyX7q0b7qaJoV9rglHRf98MUXW+F+ev02MY61bOmoAEIjrLhNmctTcA gOlS7RIZF2ZbryBBHH4bdJwRy/E/FJZyBKUc0Oc19hzoAK0ONWg=
=BO8z
-----END PGP SIGNATURE-----
Oooh, how I wish people could think more about the impact on translations, when
changing templates these days, where trixie's development cycle is nearly over ...
Can this be reverted please?
Hi,
Am 22. Januar 2025 00:01:09 MEZ schrieb Aurelien Jarno <aurel32@debian.org>: >Hi,
On 2025-01-21 23:13, Holger Wansing wrote:
Oooh, how I wish people could think more about the impact on translations, when
changing templates these days, where trixie's development cycle is nearly over ...
Can this be reverted please?
Have you actually checked the changes at the translation level? This is >basically three changes to match actual timezone changes:
Only now.
But that's not that important anyway.
AFAICS all translations now show the "This translation is not
complete, do you want
to proceed?" warning (or similar; don't have the exact text at hand).
It doesn't matter, if there's only three or twenty new strings, we are dropped
from 25 fully translated to 0 now.
- Truk => Chuuk
- Godthab => Nuuk
- Enderbury => Kanton
In the case of Truk and Godthab, I manually fixed the translation that
were already translating Truk as Chuuk and Godthab as Nuuk.
I think this will not work, when you add the translations into
the po files directly in the package.
Translations have to be put into the po files in the "d-i" repo (sublevelX/<lang>.po).
d-i packages are different compared to "normal" packages.
Also please note that all the Cyprus changes were already shipped in >tzsetup templates, just not offered in the po files, as all the previous >uploaders never committed the po changes from the automatically
generated templates...
I don't get your point here...
I am fine reverting the 3 changes above. But at the end is do we want to >provide correct translation of the wrong timezone or the correct >untranslated timezone.
We could indeed have both - if there was more time until the release...
I saw this already frequently with previous releases: when the freeze
is in sight, development work starts for d-i.
Anyway, we will see, how that goes.
Before the next alpha/beta, I will insert the English text into the translated strings as well, at least for the above mentioned languages,
when translators don't act until then.
On 2025-01-21 23:13, Holger Wansing wrote:
Oooh, how I wish people could think more about the impact on translations, when
changing templates these days, where trixie's development cycle is nearly over ...
Can this be reverted please?
Have you actually checked the changes at the translation level? This is >basically three changes to match actual timezone changes:
- Truk => Chuuk
- Godthab => Nuuk
- Enderbury => Kanton
In the case of Truk and Godthab, I manually fixed the translation that
were already translating Truk as Chuuk and Godthab as Nuuk.
Also please note that all the Cyprus changes were already shipped in
tzsetup templates, just not offered in the po files, as all the previous >uploaders never committed the po changes from the automatically
generated templates...
I am fine reverting the 3 changes above. But at the end is do we want to >provide correct translation of the wrong timezone or the correct
untranslated timezone.
[ Aurelien Jarno ]
* Replace legacy timezones with their modern counterparts. Closes: #1055541.
* Update cities/zones that have been renamed.
* Add templates for Cyprus.
Hi,
Debian FTP Masters <ftpmaster@ftp-master.debian.org> wrote (Tue, 21 Jan 2025 21:37:53 +0000):
[ Aurelien Jarno ]
* Replace legacy timezones with their modern counterparts. Closes: #1055541.
* Update cities/zones that have been renamed.
* Add templates for Cyprus.
Tests have shown, that Cyprus as country is only visible, when looking under Europe as continent.
Is this correct, since the timezone strings are named "Asia/... " ?
Asia/Nicosia (most of Cyprus)
Asia/Famagusta (Northern Cyprus)
Looks inconsistent to me.
[1] https://en.wikipedia.org/wiki/Cyprus
Hello Holger,
On Sun, 2025-01-26 at 15:00 +0100, Holger Wansing wrote:
Hi,
Debian FTP Masters <ftpmaster@ftp-master.debian.org> wrote (Tue, 21 Jan 2025 21:37:53 +0000):
[ Aurelien Jarno ]
* Replace legacy timezones with their modern counterparts. Closes: #1055541.
* Update cities/zones that have been renamed.
* Add templates for Cyprus.
Tests have shown, that Cyprus as country is only visible, when looking under
Europe as continent.
Is this correct, since the timezone strings are named "Asia/... " ?
Asia/Nicosia (most of Cyprus)
Asia/Famagusta (Northern Cyprus)
Looks inconsistent to me.
Cyprus is a country located in Western Asia, according to Wikipedia [1].
So, yeah, it should not be listed under Europe.
Adrian
[1] https://en.wikipedia.org/wiki/Cyprus
--
.''`. John Paul Adrian Glaubitz
: :' : Debian Developer
`. `' Physicist
`- GPG: 62FF 8A75 84E0 2956 9546 0006 7426 3B37 F5B5 F913
Hello Holger,
On Sun, 2025-01-26 at 15:00 +0100, Holger Wansing wrote:
Hi,
Debian FTP Masters <ftpmaster@ftp-master.debian.org> wrote (Tue, 21 Jan 2025 21:37:53 +0000):
[ Aurelien Jarno ]
* Replace legacy timezones with their modern counterparts. Closes: #1055541.
* Update cities/zones that have been renamed.
* Add templates for Cyprus.
Tests have shown, that Cyprus as country is only visible, when looking under
Europe as continent.
Is this correct, since the timezone strings are named "Asia/... " ?
Asia/Nicosia (most of Cyprus)
Asia/Famagusta (Northern Cyprus)
Looks inconsistent to me.
Cyprus is a country located in Western Asia, according to Wikipedia [1].
So, yeah, it should not be listed under Europe.
On Sun, 2025-01-26 at 15:00 +0100, Holger Wansing wrote:(...)
Tests have shown, that Cyprus as country is only visible, when looking under >> Europe as continent.
Is this correct, since the timezone strings are named "Asia/... " ?
Cyprus is a country located in Western Asia, according to Wikipedia [1].
So, yeah, it should not be listed under Europe.
Adrian
[1] https://en.wikipedia.org/wiki/Cyprus
On Sun, 2025-01-26 at 15:00 +0100, Holger Wansing wrote:
Hi,
Debian FTP Masters <ftpmaster@ftp-master.debian.org> wrote (Tue, 21 Jan 2025 21:37:53 +0000):
[ Aurelien Jarno ]
* Replace legacy timezones with their modern counterparts. Closes: #1055541.
* Update cities/zones that have been renamed.
* Add templates for Cyprus.
Tests have shown, that Cyprus as country is only visible, when looking under
Europe as continent.
Is this correct, since the timezone strings are named "Asia/... " ?
Asia/Nicosia (most of Cyprus)
Asia/Famagusta (Northern Cyprus)
[...]Looks inconsistent to me.
It seems to be a discrepancy between upstream tzdata which, consider Cyprus in Asia, and localechooser, which considers Cyprus in Europe:
https://salsa.debian.org/installer-team/localechooser/-/blob/master/regionmap?ref_type=heads#L167
According to the same source, "Although it is geographically located in
West Asia, its cultural identity and geopolitical make-up are
overwhelmingly Southeast European."
So I suspect most Cyprus inhabitants expect to see it under Europe.
What is more important, geographical accuracy or users expectations ?
Naive question: is it possible to show it under both regions ?
Hi,
Aurelien Jarno <aurel32@debian.org> wrote (Sun, 26 Jan 2025 18:30:04 +0100):
On Sun, 2025-01-26 at 15:00 +0100, Holger Wansing wrote:
Hi,
Debian FTP Masters <ftpmaster@ftp-master.debian.org> wrote (Tue, 21 Jan 2025 21:37:53 +0000):
[ Aurelien Jarno ]
* Replace legacy timezones with their modern counterparts. Closes: #1055541.
* Update cities/zones that have been renamed.
* Add templates for Cyprus.
Tests have shown, that Cyprus as country is only visible, when looking under
Europe as continent.
Is this correct, since the timezone strings are named "Asia/... " ?
Asia/Nicosia (most of Cyprus)
Asia/Famagusta (Northern Cyprus)
[...]Looks inconsistent to me.
It seems to be a discrepancy between upstream tzdata which, consider Cyprus in Asia, and localechooser, which considers Cyprus in Europe:
https://salsa.debian.org/installer-team/localechooser/-/blob/master/regionmap?ref_type=heads#L167
I see. But since we did not receive any complaints in the past about mapping Cyprus to Europe, that's likely ok.
The real issue seems to be, that the displayed choices include the continent as
Asia/Nicosia (most of Cyprus)
Asia/Famagusta (Northern Cyprus)
This is not the case for any other timezone. It should be
Nicosia (most of Cyprus)
Famagusta (Northern Cyprus)
Then the discrepancy from above is no longer an issue (for the user in d-i).
Moreover, this message is lacking the declaration of the sublevel,
that's why the above strings are in sublevel1, while all others from
tzsetup are in sublevel3.
I have attached a patch to fix all the above.
I have attached a patch to fix all the above.
Thanks, that looks good. Don't hesitate to tell me if you want me to
commit it and do the upload.
On 2025-01-26 16:59, John Paul Adrian Glaubitz wrote:
Cyprus is a country located in Western Asia, according to Wikipedia [1].
So, yeah, it should not be listed under Europe.
It seems to be a discrepancy between upstream tzdata which, consider Cyprus in Asia, and localechooser, which considers Cyprus in Europe:
| Sysop: | Keyop |
|---|---|
| Location: | Huddersfield, West Yorkshire, UK |
| Users: | 483 |
| Nodes: | 16 (2 / 14) |
| Uptime: | 15:51:42 |
| Calls: | 9,617 |
| Calls today: | 3 |
| Files: | 13,692 |
| Messages: | 6,156,369 |