1. Forum
  2. Usenet
  3. LINUX.DEBIAN.BUGS.DIST

  • Bug#1099778: ITP: golang-github-gosimple-unidecode -- Unicode translite

    From Luca Soler@21:1/5 to All on Fri Mar 7 23:30:02 2025
    XPost: linux.debian.devel

    Package: wnpp
    Severity: wishlist
    Owner: Luca Soler <luca.soler@proton.me>
    X-Debbugs-CC: debian-devel@lists.debian.org, debian-go@lists.debian.org

    * Package name    : golang-github-gosimple-unidecode
      Version         : 1.0.1-1
      Upstream Author : GoSimple
    * URL             : https://github.com/gosimple/unidecode
    * License         : Apache-2.0
      Programming Lang: Go
      Description     : Unicode transliterator in Golang - Replaces non-ASCII characters with their ASCII approximations.

     unidecode
     .
     Go Reference (https://pkg.go.dev/github.com/gosimple/unidecode) Tests  (https://github.com/gosimple/unidecode/actions/workflows/tests.yml)
     .
     Unicode transliterator in Golang - Replaces non-ASCII characters with
     their ASCII approximations.
     .
     Fork of (https://github.com/rainycape/unidecode)
     .
     Example
     .
       package main
     .
       import (
        "fmt"
     .
        "github.com/gosimple/unidecode"
       )
     .
       func main() {
        decoded := unidecode.Unidecode("Łódź")
        fmt.Println(decoded)
        // Output: Lodz
       }
     .
     Requests or bugs?
     .
     (https://github.com/gosimple/unidecode/issues)
     .
     Installation
     .
       go get -u github.com/gosimple/unidecode
     .
     Benchmark
     .
       go test -run=NONE -bench=. -benchmem -count=6 ./... > old.txt
       # make changes
       go test -run=NONE -bench=. -benchmem -count=6 ./... > new.txt
     .
       go install golang.org/x/perf/cmd/benchstat@latest
     .
       benchstat old.txt new.txt
     .
     Add new characters
     .
      1. Edit table.txt file.
      2. Rebuild table.go file:
           go run ./make_table.go

    Indirect dependency of apptainer, needed to fix golang-github-gosimple-slug. This package will be maintained within the Debian Go Packaging Team.

    As this is my first ITP, I would appreciate any feedback if I have made any mistakes. I have also requested access to the Salsa repository to push the package.

    --
    Luca

    --- SoupGate-Win32 v1.05
    * Origin: fsxNet Usenet Gateway (21:1/5)
  • From Simon Josefsson@21:1/5 to Luca Soler on Sat Mar 8 00:00:01 2025
    Luca Soler <luca.soler@proton.me> writes:

    As this is my first ITP, I would appreciate any feedback if I have made any mistakes. I have also requested access to the Salsa repository to push the package.

    I approved you now, please push and I will try to give you some
    packaging review.

    /Simon

    -----BEGIN PGP SIGNATURE-----

    iQNoBAEWCAMQFiEEo8ychwudMQq61M8vUXIrCP5HRaIFAmfLeVsUHHNpbW9uQGpv c2Vmc3Nvbi5vcmfCHCYAmDMEXJLOtBYJKwYBBAHaRw8BAQdACIcrZIvhrxDBkK9f V+QlTmXxo2naObDuGtw58YaxlOu0JVNpbW9uIEpvc2Vmc3NvbiA8c2ltb25Aam9z ZWZzc29uLm9yZz6IlgQTFggAPgIbAwULCQgHAgYVCAkKCwIEFgIDAQIeAQIXgBYh BLHSvRN1vst4TPT4xNc89jjFPAa+BQJl/YgIBQkLehFUAAoJENc89jjFPAa+CboA +wUa06RD5e5VTCxvSWtPS75Wq2qBeYGZnf0jvUMxa2n4AP4xkUeAPPnNuMsTm2fs FCDIGaEM2Yn6Vb2huzzT1Fw/BLgzBFySz4EWCSsGAQQB2kcPAQEHQOxTCIOaeXAx I2hIX4HK9bQTpNVei708oNr1Klm8qCGKiPUEGBYIACYCGwIWIQSx0r0Tdb7LeEz0 +MTXPPY4xTwGvgUCZf2IKwUJC3oQqgCBdiAEGRYIAB0WIQSjzJyHC50xCrrUzy9R cisI/kdFogUCXJLPgQAKCRBRcisI/kdFoqdMAQCgH45aseZgIrwKOvUOA9QfsmeE 8GZHYNuFHmM9FEQS6AD6A4x5aYvoY6lo98pgtw2HPDhmcCXFItjXCrV4A0GmJA4J ENc89jjFPAa+GcYA/26YQY05bLtnXiIjTiAzrGQrRXxTHPA8Av7TDFHvIetWAP9s HSoU8OfTwmTiEnGwLlsV7QJclZg3YNz/Ypcp9TqQBrg4BFySz2oSCisGAQQBl1UB BQEBB0AxlRumDW6nZY7A+VCfek9VpEx6PJmdJyYPt3lNHMd6HAMBCAeIfgQYFggA JgIbDBYhBLHSvRN1vst4TPT4xNc89jjFPAa+BQJl/YgwBQkLehDGAAoJENc89jjF PAa+phoA/jrDqIrl/55vUMBhIQv+TP635d2iCTEnyFmbUcP9+gh6APoDsXalVd2c OGxQtSC+TF8PkZMn1TLkJKAjVxr+xx40AgAKCRBRcisI/kdFos4ZAP0SLkCqqVdP YiBSYxmBqx/Bqv0hwkV4Hu0HRZeBE5ObtAD/Y/eAjnflkXicdqnln4a+IVaxxYcR 57bidOY1JU/z/As=
    =vMPe
    -----END PGP SIGNATURE-----

    --- SoupGate-Win32 v1.05
    * Origin: fsxNet Usenet Gateway (21:1/5)
  • From Luca Soler@21:1/5 to All on Sat Mar 8 00:20:01 2025
    This is an OpenPGP/MIME signed message (RFC 4880 and 3156) -----------------------cca6877d9bc71af402546a5eb29cfb70 Content-Transfer-Encoding: quoted-printable
    Content-Type: text/plain;charset=utf-8

    Hi Simon,

    Thanks!

    I pushed everything here: https://salsa.debian.org/go-team/packages/golang-github-gosimple-unidecode/-/tree/debian/sid?ref_type=heads

    I also pushed the lastest version of golang-github-gosimple-slug: https://salsa.debian.org/go-team/packages/golang-github-gosimple-unidecode/-/tree/debian/sid?ref_type=heads

    Can you explain me what is the workflow to get theses packages
    available on sid (another ITP for slug, or anything else)?
    --
    Luca
    -----------------------cca6877d9bc71af402546a5eb29cfb70
    Content-Type: application/pgp-keys; filename="publickey - luca.soler@proton.me - 0xCFA702A4.asc"; name="publickey - luca.soler@proton.me - 0xCFA702A4.asc"
    Content-Transfer-Encoding: base64
    Content-Disposition: attachment; filename="publickey - luca.soler@proton.me - 0xCFA702A4.asc"; name="publickey - luca.soler@proton.me - 0xCFA702A4.asc"

    LS0tLS1CRUdJTiBQR1AgUFVCTElDIEtFWSBCTE9DSy0tLS0tCgp4ak1FWjZObU9oWUpLd1lCQkFI YVJ3OEJBUWRBQzlSNUdUU1dYdUZwak1BQXlVYmNaWWlGVVFNdDNwTDEKNFF3bTJ3U0dZVzdOSzJ4 MVkyRXVjMjlzWlhKQWNISnZkRzl1TG0xbElEeHNkV05oTG5OdmJHVnlRSEJ5CmIzUnZiaTV0WlQ3 Q3dCRUVFeFlLQUlNRmdtZWpaam9EQ3drSENaQXRnMHlHN3ZZN2IwVVVBQUFBQUFBYwpBQ0J6WVd4 MFFHNXZkR0YwYVc5dWN5NXZjR1Z1Y0dkd2FuTXViM0puU2ZFQ0FRZmJCVXY0SXc3Y2dsVm4KV0RV S3VuYmNCYUJnZ1VacnFNKzFSY29ERlFvSUJCWUFBZ0VDR1FFQ213TUNIZ0VXSVFUUHB3S2tSU0xn CmNldlR5SFF0ZzB5Rzd2WTdid0FBLzRZQkFLUE03N2RET2ZkdlA2SkhCTXAvaUJmQXFqOFJ3elZL RmQrMApJU01DZEVWSEFRQzFtRHg3cUltVitSMFhzR2VSUzVtWFc3UkxHZVhBYmplNWt1V3NRS2V2 RHM0NEJHZWoKWmpvU0Npc0dBUVFCbDFVQkJRRUJCMEFVamQvNGQ5WXFkT0dOUGpmVzIzbml0NCtK Y3Nmem53WWFVVDkrCnZWdG5SZ01CQ0FmQ3ZnUVlGZ29BY0FXQ1o2Tm1PZ21RTFlOTWh1NzJPMjlG RkFBQUFBQUFIQUFnYzJGcwpkRUJ1YjNSaGRHbHZibk11YjNCbGJuQm5jR3B6TG05eVo5VGY2YWli QWs2Nit0WFNIbTRaTHdZelJSbDIKdEw5VzJaYmlPTm5QTU9uYkFwc01GaUVFejZjQ3BFVWk0SEhy MDhoMExZTk1odTcyTzI4QUFLczRBUHNIClUvd3UrRXNXVlZ3cXhmc01wWWRuRW5kbkgxbGZhaDBI RW55THdCNmthQUVBd1ArSGpJbjNXZDJFZHdkMwppZlFTR0M0L0IvalN5NThoc0hWQnovQnpIdzg9 Cj05RW84Ci0tLS0tRU5EIFBHUCBQVUJMSUMgS0VZIEJMT0NLLS0tLS0K -----------------------cca6877d9bc71af402546a5eb29cfb70--

    -----BEGIN PGP SIGNATURE-----
    Version: ProtonMail

    wrsEARYKAG0FgmfLe/4JkC2DTIbu9jtvRRQAAAAAABwAIHNhbHRAbm90YXRp b25zLm9wZW5wZ3Bqcy5vcmdCNAnjsww9SyQIr0CYKXvMNnmD9drEMOp1X/nO aMoAVhYhBM+nAqRFIuBx69PIdC2DTIbu9jtvAAAPWAEAyImbXyGgRt4ugDAg TZgLQT79vnQcoNj4SxmPowFFJssBAIUMgZw2UwFTGBXmE38cXCMpzd2cdSF9
    lTWXHeJCzu8B
    =8Dpy
    -----END PGP SIGNATURE-----

    --- SoupGate-Win32 v1.05
    * Origin: fsxNet Usenet Gateway (21:1/5)
  • From Simon Josefsson@21:1/5 to Luca Soler on Sat Mar 8 00:30:01 2025
    (I took the liberty to clear-text reply to your e-mail, I assume you
    want this to be public...)

    Luca Soler <luca.soler@proton.me> writes:

    Hi Simon,

    Thanks!

    I pushed everything here: https://salsa.debian.org/go-team/packages/golang-github-gosimple-unidecode/-/tree/debian/sid?ref_type=heads

    I also pushed the lastest version of golang-github-gosimple-slug: https://salsa.debian.org/go-team/packages/golang-github-gosimple-unidecode/-/tree/debian/sid?ref_type=heads

    Can you explain me what is the workflow to get theses packages
    available on sid (another ITP for slug, or anything else)?

    Some nits:

    1) Looks like you are using a old dh-make-golang, you would want
    Build-Depends: dh-golang-sequence and not dh-golang.

    2) Bump Standards-Version.

    3) You have TODO's remaining in debian/copyright.

    4) LICENSE file contains another copyright notice you want to look into.

    5) You should fix lintian complaints, e.g., the Description: section in debian/control is too long.

    Look at the 'lintian' (and other jobs) output in the pipeline:

    https://salsa.debian.org/jas/golang-github-gosimple-slug/-/pipelines/828469 https://salsa.debian.org/jas/golang-github-gosimple-unidecode/-/pipelines/828472

    After you've fixed everything and it looks good, if you are a DD you
    upload it to NEW or go find some DD to do sponsor the upload.

    /Simon

    -----BEGIN PGP SIGNATURE-----

    iQNoBAEWCAMQFiEEo8ychwudMQq61M8vUXIrCP5HRaIFAmfLfjUUHHNpbW9uQGpv c2Vmc3Nvbi5vcmfCHCYAmDMEXJLOtBYJKwYBBAHaRw8BAQdACIcrZIvhrxDBkK9f V+QlTmXxo2naObDuGtw58YaxlOu0JVNpbW9uIEpvc2Vmc3NvbiA8c2ltb25Aam9z ZWZzc29uLm9yZz6IlgQTFggAPgIbAwULCQgHAgYVCAkKCwIEFgIDAQIeAQIXgBYh BLHSvRN1vst4TPT4xNc89jjFPAa+BQJl/YgIBQkLehFUAAoJENc89jjFPAa+CboA +wUa06RD5e5VTCxvSWtPS75Wq2qBeYGZnf0jvUMxa2n4AP4xkUeAPPnNuMsTm2fs FCDIGaEM2Yn6Vb2huzzT1Fw/BLgzBFySz4EWCSsGAQQB2kcPAQEHQOxTCIOaeXAx I2hIX4HK9bQTpNVei708oNr1Klm8qCGKiPUEGBYIACYCGwIWIQSx0r0Tdb7LeEz0 +MTXPPY4xTwGvgUCZf2IKwUJC3oQqgCBdiAEGRYIAB0WIQSjzJyHC50xCrrUzy9R cisI/kdFogUCXJLPgQAKCRBRcisI/kdFoqdMAQCgH45aseZgIrwKOvUOA9QfsmeE 8GZHYNuFHmM9FEQS6AD6A4x5aYvoY6lo98pgtw2HPDhmcCXFItjXCrV4A0GmJA4J ENc89jjFPAa+GcYA/26YQY05bLtnXiIjTiAzrGQrRXxTHPA8Av7TDFHvIetWAP9s HSoU8OfTwmTiEnGwLlsV7QJclZg3YNz/Ypcp9TqQBrg4BFySz2oSCisGAQQBl1UB BQEBB0AxlRumDW6nZY7A+VCfek9VpEx6PJmdJyYPt3lNHMd6HAMBCAeIfgQYFggA JgIbDBYhBLHSvRN1vst4TPT4xNc89jjFPAa+BQJl/YgwBQkLehDGAAoJENc89jjF PAa+phoA/jrDqIrl/55vUMBhIQv+TP635d2iCTEnyFmbUcP9+gh6APoDsXalVd2c OGxQtSC+TF8PkZMn1TLkJKAjVxr+xx40AgAKCRBRcisI/kdFoiftAQDvS9TcGfBP /iU3342AmN8oamCGdo0nq+2VMJVFtxfMdwD5AejyrH/C7Loy2F9LDqMf7u3TdDsm PpFz2szsTw6oSQo=
    =SMxw
    -----END PGP SIGNATURE-----

    --- SoupGate-Win32 v1.05
    * Origin: fsxNet Usenet Gateway (21:1/5)
  • From Luca Soler@21:1/5 to All on Sat Mar 8 09:10:01 2025
    This is an OpenPGP/MIME signed message (RFC 4880 and 3156) -----------------------3c1b0a9e913c6990c9ddd27bd6cc4b02 Content-Transfer-Encoding: quoted-printable
    Content-Type: text/plain;charset=utf-8

    (I took the liberty to clear-text reply to your e-mail, I assume you
    want this to be public...)

    Exactly, as this is the first time I use the BTS system, I put the BTS in Cc. Was that the correct way to proceed?

    Some nits:

    1) Looks like you are using a old dh-make-golang, you would want Build-Depends: dh-golang-sequence and not dh-golang.

    2) Bump Standards-Version.

    That should be ok now.

    3) You have TODO's remaining in debian/copyright.

    4) LICENSE file contains another copyright notice you want to look into.

    I updated debian/copyright for both packages. Can you tell me if that's ok now?

    5) You should fix lintian complaints, e.g., the Description: section in debian/control is too long.

    Look at the 'lintian' (and other jobs) output in the pipeline:

    Ok, I just let warnings related to non-maintainer upload in d/changelog.

    After you've fixed everything and it looks good, if you are a DD you
    upload it to NEW or go find some DD to do sponsor the upload.

    As I'm not a DD can you sponsor me for this upload?
    Otherwise lolando@debian.org will probably take a look.

    Thank you very much for your review. It's really appreciated!
    --
    Luca
    -----------------------3c1b0a9e913c6990c9ddd27bd6cc4b02
    Content-Type: application/pgp-keys; filename="publickey - luca.soler@proton.me - 0xCFA702A4.asc"; name="publickey - luca.soler@proton.me - 0xCFA702A4.asc"
    Content-Transfer-Encoding: base64
    Content-Disposition: attachment; filename="publickey - luca.soler@proton.me - 0xCFA702A4.asc"; name="publickey - luca.soler@proton.me - 0xCFA702A4.asc"

    LS0tLS1CRUdJTiBQR1AgUFVCTElDIEtFWSBCTE9DSy0tLS0tCgp4ak1FWjZObU9oWUpLd1lCQkFI YVJ3OEJBUWRBQzlSNUdUU1dYdUZwak1BQXlVYmNaWWlGVVFNdDNwTDEKNFF3bTJ3U0dZVzdOSzJ4 MVkyRXVjMjlzWlhKQWNISnZkRzl1TG0xbElEeHNkV05oTG5OdmJHVnlRSEJ5CmIzUnZiaTV0WlQ3 Q3dCRUVFeFlLQUlNRmdtZWpaam9EQ3drSENaQXRnMHlHN3ZZN2IwVVVBQUFBQUFBYwpBQ0J6WVd4 MFFHNXZkR0YwYVc5dWN5NXZjR1Z1Y0dkd2FuTXViM0puU2ZFQ0FRZmJCVXY0SXc3Y2dsVm4KV0RV S3VuYmNCYUJnZ1VacnFNKzFSY29ERlFvSUJCWUFBZ0VDR1FFQ213TUNIZ0VXSVFUUHB3S2tSU0xn CmNldlR5SFF0ZzB5Rzd2WTdid0FBLzRZQkFLUE03N2RET2ZkdlA2SkhCTXAvaUJmQXFqOFJ3elZL RmQrMApJU01DZEVWSEFRQzFtRHg3cUltVitSMFhzR2VSUzVtWFc3UkxHZVhBYmplNWt1V3NRS2V2 RHM0NEJHZWoKWmpvU0Npc0dBUVFCbDFVQkJRRUJCMEFVamQvNGQ5WXFkT0dOUGpmVzIzbml0NCtK Y3Nmem53WWFVVDkrCnZWdG5SZ01CQ0FmQ3ZnUVlGZ29BY0FXQ1o2Tm1PZ21RTFlOTWh1NzJPMjlG RkFBQUFBQUFIQUFnYzJGcwpkRUJ1YjNSaGRHbHZibk11YjNCbGJuQm5jR3B6TG05eVo5VGY2YWli QWs2Nit0WFNIbTRaTHdZelJSbDIKdEw5VzJaYmlPTm5QTU9uYkFwc01GaUVFejZjQ3BFVWk0SEhy MDhoMExZTk1odTcyTzI4QUFLczRBUHNIClUvd3UrRXNXVlZ3cXhmc01wWWRuRW5kbkgxbGZhaDBI RW55THdCNmthQUVBd1ArSGpJbjNXZDJFZHdkMwppZlFTR0M0L0IvalN5NThoc0hWQnovQnpIdzg9 Cj05RW84Ci0tLS0tRU5EIFBHUCBQVUJMSUMgS0VZIEJMT0NLLS0tLS0K -----------------------3c1b0a9e913c6990c9ddd27bd6cc4b02--

    -----BEGIN PGP SIGNATURE-----
    Version: ProtonMail

    wrsEARYKAG0FgmfL+dIJkC2DTIbu9jtvRRQAAAAAABwAIHNhbHRAbm90YXRp b25zLm9wZW5wZ3Bqcy5vcmcdrUXNtBKXDassd3vjRxgeumMKKkO3QVfA/MPJ 9PF+AhYhBM+nAqRFIuBx69PIdC2DTIbu9jtvAADlaQEA2XohVw696JfuOo1k 1lNXtDPZ90wTiRgqhp+qFbiyV/gBAJ8hC8EfyTaK8a+tU7bLKa0oz1NreWFh
    ovkjxKmOO+sC
    =aQqT
    -----END PGP SIGNATURE-----

    --- SoupGate-Win32 v1.05
    * Origin: fsxNet Usenet Gateway (21:1/5)