Package: orphan-sysvinit-scripts
Version: 0.19
Severity: wishlist

Dear Maintainer,

the <censored> kmod maintainer removed the init script (again a case
without handing the init script to you or an NEWS entry).

Could you please add the script?

Many greetings,

Stephan

--
| If your life was a horse, you'd have to shoot it. |

--- SoupGate-Win32 v1.05
* Origin: fsxNet Usenet Gateway (21:1/5)

Hi all,

On Mon, 10 Mar 2025 14:47:18 +0100
Stephan Seitz <stse+debianbugs@rootsland.net> wrote:

Package: orphan-sysvinit-scripts
Version: 0.19
Severity: wishlist

Dear Maintainer,

the <censored> kmod maintainer removed the init script (again a case
without handing the init script to you or an NEWS entry).

removed in version 34-1 https://salsa.debian.org/md/kmod/-/commit/8ca034958ad7d1734087a78078be4897209ab22e

Could you please add the script?

In my opinion this fits better in initscript package.

Best,
Lorenzo

Many greetings,

Stephan

--- SoupGate-Win32 v1.05
* Origin: fsxNet Usenet Gateway (21:1/5)

Control: reassign -1 kmod 34.1-1
Control: severity -1 serious

[Justification: breaks unrelated software]

Lorenzo,

On Mon, Mar 10, 2025 at 03:23:56PM +0100, Lorenzo wrote:

Could you please add the script?

In my opinion this fits better in initscript package.

Yes, that may be true, but src:sysvinit is about to freeze.

Marco,

Would you please revert this change? To remove the initscript at this stage in the release cycle is a big and very disruptive change. Particularly so without any coordination with the people maintaining the non-systemd inits ecosystem.

If /etc/init.d/kmod was to be transferred to another package, the best fit might
be bin:initscripts. However, src:sysvinit is an essential toolchain package and enters freeze later this week.

We would be happy to work together with you to achieve that transition early in the forky cycle, if you wanted.

Thanks very much

Mark

--- SoupGate-Win32 v1.05
* Origin: fsxNet Usenet Gateway (21:1/5)

On Mar 10, Mark Hindley <mark@hindley.org.uk> wrote:

At the moment sysadmin changes to /etc/init.d/kmod will be lost because kmod.maintscript has rm_conffile /etc/init.d/kmod 34-1~

That would need to be removed so that initscripts can take over the existing /etc/init.d/kmod.

Sure, let me know when you will be ready.

--
ciao,
Marco

-----BEGIN PGP SIGNATURE-----

iHUEABYIAB0WIQQnKUXNg20437dCfobLPsM64d7XgQUCZ88VDQAKCRDLPsM64d7X gUrvAQDGi4Oz61oEJuU+H4XuxY3L1qNzLaLEaZNf9+Zv9+ycHAD/S/AQCzn+6liJ 5+M2w3ivolhWP79p/4SZduXm9Fp3Rg0=
=Hs/U
-----END PGP SIGNATURE-----

--- SoupGate-Win32 v1.05
* Origin: fsxNet Usenet Gateway (21:1/5)

On Mar 10, Mark Hindley <mark@hindley.org.uk> wrote:

Would you please revert this change? To remove the initscript at this stage in

No, I will not dedicate any more resources to sysvinit support.

If /etc/init.d/kmod was to be transferred to another package, the best fit might
be bin:initscripts. However, src:sysvinit is an essential toolchain package and
enters freeze later this week.

Be quick then, you still have time!

--
ciao,
Marco

-----BEGIN PGP SIGNATURE-----

iHUEABYIAB0WIQQnKUXNg20437dCfobLPsM64d7XgQUCZ88QEAAKCRDLPsM64d7X gTFtAP4muYr5vEQN3+TyxH6z2DXmEq6+ObOilUkOmVs/i7r8hgEAt9HHAmLvflOL qOvq8urw4szBSB26JCMgGPLyGR19kQY=
=77GZ
-----END PGP SIGNATURE-----

--- SoupGate-Win32 v1.05
* Origin: fsxNet Usenet Gateway (21:1/5)

On Mon, Mar 10, 2025 at 05:36:29PM +0100, Marco d'Itri wrote:

On Mar 10, Mark Hindley <mark@hindley.org.uk> wrote:

At the moment sysadmin changes to /etc/init.d/kmod will be lost because kmod.maintscript has rm_conffile /etc/init.d/kmod 34-1~

That would need to be removed so that initscripts can take over the existing
/etc/init.d/kmod.

Sure, let me know when you will be ready.

src:sysvinit 3.14-4 with Breaks and Replaces kmod (<< 34.1-1) is in review and testing.

Mark

--- SoupGate-Win32 v1.05
* Origin: fsxNet Usenet Gateway (21:1/5)

On Mon, Mar 10, 2025 at 06:10:39PM +0100, Marco d'Itri wrote:

OK, but do I need do do anything else other than removing
kmod.maintscript?

You also need to rework or revert

https://salsa.debian.org/md/kmod/-/commit/c2ae42ca3a338fba0f190e3a61a635d386b1e8fa

as also mentioned in https://bugs.debian.org/1100072. Kmod shouldn't be using rm
on the symlinks. At least use update-rc.d and check if /etc/init.d/kmod doesn't still exist (i.e hasn't been taken over). If you are unsure, you might want to look at Michael Biebl's way of dealing with this situation in udev.postinst.

Mark

--- SoupGate-Win32 v1.05
* Origin: fsxNet Usenet Gateway (21:1/5)

Control: retitle -1 Kmod removes LSB initscript and startup links unconditionally which breaks non-systemd systems
Control: severity -1 serious

These changes are already causing breakage in non-systemd systems[1]. Specifically, even where the sysadmin has explicitly kept a copy of /etc/init.d/kmod the kmod postinst will remove it and the symlinks regardless. To avoid further spread, the broken version in sid should not migrate to trixie. Hence, raising to RC severity.

Mark

[1] https://bugs.debian.org/1100072

--- SoupGate-Win32 v1.05
* Origin: fsxNet Usenet Gateway (21:1/5)

Control: severity -1 wishlist

Maybe I was not clear enough: I will really not spend more time on
sysvinit support, so if you want this change then send a tested patch.
This is not RC, so stop adjusting the severity.

--
ciao,
Marco

-----BEGIN PGP SIGNATURE-----

iHUEABYIAB0WIQQnKUXNg20437dCfobLPsM64d7XgQUCZ9AE5AAKCRDLPsM64d7X gVzOAP93EUygIBY2PDCuvgmSUBjzUsu4aWiqybzgc7m4TdnjYwEA/JaeYZN20iDh z+oqbF4s1fan0iwc3e4QNolJs0mJVA0=
=r0V0
-----END PGP SIGNATURE-----

--- SoupGate-Win32 v1.05
* Origin: fsxNet Usenet Gateway (21:1/5)

Control: tags -1 patch

Marco,

On Tue, Mar 11, 2025 at 10:39:48AM +0100, Marco d'Itri wrote:

so if you want this change then send a tested patch.

This patch works for me and is similar in functionality to udev.postinst.

Mark

commit 070ef4aba05e3c85bd28a6e726223002c4a34b7e
Author: Mark Hindley <mark@hindley.org.uk>
Date: Wed Mar 12 08:16:57 2025 +0000

d/kmod.postinst: remove LSB symlinks with update-rc.d but only if /etc/init.d/kmod doesn't exist.

The test for /etc/init.d/kmod can be removed once the patch for #680293 is
accepted.

Closes: #1100035

diff --git a/debian/kmod.postinst b/debian/kmod.postinst
index a3bd12b..12a21c2 100644
--- a/debian/kmod.postinst
+++ b/debian/kmod.postinst
@@ -33,7 +33,10 @@ sysvinit_cleanup() {
[ "$2" ] || return 0

dpkg --compare-versions $2 lt 34-3~ || return 0
- rm -f /etc/rcS.d/[SK]*kmod
+ # update-rc.d removes symlinks even if LSB initscript exists, contrary to
+ # update-rc-d(8). See #680293. Can be removed once it is fixed.
+ [ -f /etc/init.d/kmod ] && return 0
+ update-rc.d kmod remove || true
}

case "$1" in

--- SoupGate-Win32 v1.05
* Origin: fsxNet Usenet Gateway (21:1/5)

On 12/03/2025 13:23, Marco d'Itri wrote:

On Mar 12, Mark Hindley <mark@hindley.org.uk> wrote:

+  update-rc.d kmod remove || true

Why the "|| true"?

update-rc.d does not fail even the symlinks have already been removed.

I didn't write the patch, but it seems sensible to me - if that does
fail for whatever reason, you don't want the postinst to fail, since
presumably you don't want to abort the kmod upgrade if this removal does
fail?

I'm sure Mark will remove the || true if you want, though.

Regards,

Matthew

--- SoupGate-Win32 v1.05
* Origin: fsxNet Usenet Gateway (21:1/5)

On Mar 12, Mark Hindley <mark@hindley.org.uk> wrote:

+ update-rc.d kmod remove || true

Why the "|| true"?

update-rc.d does not fail even the symlinks have already been removed.

--
ciao,
Marco

-----BEGIN PGP SIGNATURE-----

iHUEABYIAB0WIQQnKUXNg20437dCfobLPsM64d7XgQUCZ9GKugAKCRDLPsM64d7X gRKyAP9iIAh5ZH7bBVhMTdhJFqAM7IwC9+KggQbeMv/2tJjF4gEA2ojTFBEtbQh1 JVyF3MCE3hn9qLLYMHVgcnCLUyFBpwM=
=atDn
-----END PGP SIGNATURE-----

--- SoupGate-Win32 v1.05
* Origin: fsxNet Usenet Gateway (21:1/5)

On Wed, Mar 12, 2025 at 01:41:41PM +0000, Mark Hindley wrote:

Yes, at the moment "|| is redundant.

Sorry, that got garbled

Yes, at the moment "|| true" is redundant....

Mark

--- SoupGate-Win32 v1.05
* Origin: fsxNet Usenet Gateway (21:1/5)

On Wed, Mar 12, 2025 at 02:23:06PM +0100, Marco d'Itri wrote:

On Mar 12, Mark Hindley <mark@hindley.org.uk> wrote:

+ update-rc.d kmod remove || true

Why the "|| true"?

update-rc.d does not fail even the symlinks have already been removed.

Yes, at the moment "|| is redundant. But I think it will be required if /etc/init.d/kmod is present and #680293 is fixed. In that case update-rc.d will exit with an error message as documented in update-rc.d(8).

Mark

--- SoupGate-Win32 v1.05
* Origin: fsxNet Usenet Gateway (21:1/5)