• Bug#1039499: python3-dbus-tests: Please add python3-tap to Recommends

    From Simon McVittie@21:1/5 to Thomas Uhle on Thu Mar 13 14:30:01 2025
    Control: tags -1 + moreinfo

    On Mon, 26 Jun 2023 at 19:55:56 +0200, Thomas Uhle wrote:
    dbus-python already build-depends on python3-tap. Could you please
    consider to let python3-dbus-tests recommend python3-tap as well.

    What advantage would there be to users or developers if this Recommends
    was present?

    The autopkgtest already depends on python3-tap, and the tests themselves gracefully fall back to basic pass/fail output if python3-tap is not
    installed.

    smcv

    --- SoupGate-Win32 v1.05
    * Origin: fsxNet Usenet Gateway (21:1/5)
  • From Thomas Uhle@21:1/5 to Simon McVittie on Sat Mar 15 17:10:01 2025
    Control: tags -1 - moreinfo

    Hello Simon,

    you are right of course, the tests also work if python3-tap is not
    installed.

    It has been quite some time since I wrote this ticket. So IIRC, the
    output "(tap module not available)" had been the initial impulse for
    it, and I (myself) basically prefer if packages have dependencies on
    all those packages that are needed for full functionality (in one way
    or another, that is "Depends", "Recommends", or "Suggests").

    Obviously, in a TAP-only aware environment (e.g., Perl) without
    python3-tap, you would just see the final result in a summary: 100%
    passing or failing instead of anything in between [0, 100%] if only
    some of the unit tests fail. The reason for it is the implemented
    work-around in dbus_test_utils.py. Also I kind of like the clarity
    of the summary that Perl's Test::Harness provides.

    If you are worried about automatically pulling in the indirectly
    dependent packages python3-more-itertools and python3-yaml, then
    maybe adding "Suggests: python3-tap" instead could be good compromise.

    Best regards,

    Thomas Uhle



    On Thu, 13 Mar 2025, Simon McVittie wrote:

    On Mon, 26 Jun 2023 at 19:55:56 +0200, Thomas Uhle wrote:
    dbus-python already build-depends on python3-tap. Could you please consider to let python3-dbus-tests recommend python3-tap as well.

    What advantage would there be to users or developers if this Recommends was present?

    The autopkgtest already depends on python3-tap, and the tests themselves gracefully fall back to basic pass/fail output if python3-tap is not installed.

    smcv


    --- SoupGate-Win32 v1.05
    * Origin: fsxNet Usenet Gateway (21:1/5)