1. Forum
  2. Usenet
  3. LINUX.DEBIAN.BUGS.DIST

  • Bug#1100809: git-buildpackage: gbp pq export disables rename detection

    From Richard Hansen@21:1/5 to All on Tue Mar 18 22:40:01 2025
    Package: git-buildpackage
    Version: 0.9.37
    Severity: wishlist

    `gbp pq export` always passes `--no-renames` to git: <https://salsa.debian.org/agx/git-buildpackage/-/commit/762ebe190b3a48df20f0b4bdce399819db65ff89>

    This causes patches involving renames to be large, difficult to review, and difficult for devs that don't use gbp to refresh against a newer upstream version.

    Partial output from `gbp pq --verbose export`:

    gbp:debug: ['git', 'show', '--pretty=format:%an%x00%ae%x00%ad%x00%cn%x00%ce%x00%cd%x00%s%x00%f%x00%b%x00', '-z', '--date=raw', '--no-renames', '--name-status', '--no-show-signature', '78917bdfa9d4e53c12cde57760e2f0f3399827bc']
    gbp:debug: ['git', '-c', 'core.abbrev=7', '-c', 'diff.noprefix=false', 'diff', '-p', '--no-ext-diff', '--stat=80', '--summary', '--text', '--ignore-submodules=all', '--no-renames', '78917bdfa9d4e53c12cde57760e2f0f3399827bc^!', '--', '.']

    The quilt utility wraps patch, and GNU patch has supported Git's diff features such as renames and copies since 2.7, released Sep 2012: <https://git.savannah.gnu.org/cgit/patch.git/tree/NEWS?h=v2.7#n6>

    It would be nice to replace `--no-renames` with `-C` so that both renames and copies are detected.

    -- System Information:
    Debian Release: trixie/sid
    APT prefers testing-debug
    APT policy: (500, 'testing-debug'), (500, 'testing'), (250, 'unstable'), (1, 'experimental')
    Architecture: amd64 (x86_64)
    Foreign Architectures: i386

    Kernel: Linux 6.12.17-amd64 (SMP w/4 CPU threads; PREEMPT)
    Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8), LANGUAGE not set
    Shell: /bin/sh linked to /usr/bin/dash
    Init: systemd (via /run/systemd/system)
    LSM: AppArmor: enabled

    Versions of packages git-buildpackage depends on:
    ii devscripts 2.25.5
    ii git 1:2.47.2-0.1
    ii man-db 2.13.0-1
    ii python3 3.13.2-2
    ii python3-dateutil 2.9.0-3
    ii python3-yaml 6.0.2-1+b2
    ii sensible-utils 0.0.24

    Versions of packages git-buildpackage recommends:
    ii pbuilder 0.231.1
    ii pristine-tar 1.50+nmu2
    ii python3-requests 2.32.3+dfsg-4
    ii sbuild 0.88.5

    Versions of packages git-buildpackage suggests:
    pn python3-notify2 <none>
    ii sudo 1.9.16p2-1
    ii unzip 6.0-29

    -- no debconf information

    --- SoupGate-Win32 v1.05
    * Origin: fsxNet Usenet Gateway (21:1/5)