• Bug#956925: dpkg: dpkg-source: should fail before-build if patches can'

    From Tomas Janousek@21:1/5 to Jiri Palecek on Thu Mar 20 17:10:01 2025
    XPost: linux.debian.maint.dpkg

    Hello,

    On Mon, May 11, 2020 at 01:40:42AM +0200, Jiri Palecek wrote:
    OK. I have thought about those other workflows and it should be possible
    to support it while maintaining a sane function for people using quilt.
    My assumption is that when you have the whole tree in git and do not
    store .pc, as is discussed in bug 680155, dpkg should not apply the
    patches, therefore never create the .pc directory. This can be used to >distinguish these users to users with .pc metadata tracking applied
    patches. Of course the first patch heuristic is imprecise (as 680155
    shows), but it's been good enough till now so we can go along with that.

    The attached patch just checks that the .pc directory exists and if it >doesn't, applies the heuristic. If it exist, I assume the info in the
    .pc directory should be good enough to get applied patches list from.
    The patch contains a test that checks if it works under both scenarios
    (you need to have quilt installed to test it fully).

    Is there going to be any .pc directory when you (or buildd) build the
    package from scratch for the first time? I suspect not, so there's still
    the possiblity that patches will be silently skipped whenever the first
    one no longer applies cleanly (such as when you update to a new upstream version).

    Or am I missing something?

    --
    Tomáš "liskin" ("Pivník") Janoušek, https://lisk.in/

    <!DOCTYPE html>

    <html lang="" xml:lang="" xmlns="http://www.w3.org/1999/xhtml">
    <head>
    <meta charset="utf-8"/>
    <meta content="pandoc" name="generator"/>
    <meta content="width=device-width, initial-scale=1.0, user-scalable=yes" name="viewport"/>
    <title>-</title>

    </head>
    <body>
    <p style="padding: 0 0.5em">Hello,</p>
    <p class="quotelead" style="padding: 0 0.5em; margin-bottom: -1em; font-size: 80%">On Mon, May 11, 2020 at 01:40:42AM +0200, Jiri Palecek
    wrote:</p>
    <blockquote class="quote initial" style="padding: 0 0.5em; margin: 0; font-style: italic; border-left: 2px solid #666; color: #666; font-size: 80%">
    <p style="padding: 0 0.5em">OK. I have thought about those other workflows and it
    should be possible<br/>
    to support it while maintaining a sane function for people using
    quilt.<br/>
    My assumption is that when you have the whole tree in git and do
    not<br/>
    store .pc, as is discussed in bug 680155, dpkg should not apply
    the<br/>
    patches, therefore never create the .pc directory. This can be used
    to<br/>
    distinguish these users to users with .pc metadata tracking
    applied<br/>
    patches. Of course the first patch heuristic is imprecise (as
    680155<br/>
    shows), but it's been good enough till now so we can go along with
    that.</p>
    <p style="padding: 0 0.5em">The attached patch just checks that the .pc directory exists and if
    it<br/>
    doesn't, applies the heuristic. If it exist, I assume the info in
    the<br/>
    .pc directory should be good enough to get applied patches list
    from.<br/>
    The patch contains a test that checks if it works under both
    scenarios<br/>
    (you need to have quilt installed to test it fully).</p>
    </blockquote>
    <p style="padding: 0 0.5em">Is there going to be any .pc directory when you (or buildd) build the
    package from scratch for the first time? I suspect not, so there's still
    the possiblity that patches will be silently skipped whenever the first
    one no longer applies cleanly (such as when you update to a new upstream version).</p>
    <p style="padding: 0 0.5em">Or am I missing something?</p>
    <div class="signature" style="color: #999; font-family: monospace; white-space: pre; margin: 1em 0 0 0; font-size: 80%"><span class="leader">-- </span><br/>
    <pre style="line-height: 125%; padding: 0 1em"><code style="white-space: pre-wrap">Tomáš &quot;liskin&quot; (&quot;Pivník&quot;) Janoušek, https://lisk.in/
    </code></pre>
    </div>
    </body>
    </html>

    --- SoupGate-Win32 v1.05
    * Origin: fsxNet Usenet Gateway (21:1/5)