• Bug#962064: "--extra-package" option not respecting relative paths

    From Johannes Schauer Marin Rodrigues@21:1/5 to samueloph@debian.org on Thu Apr 10 01:20:01 2025
    Control: tag -1 + unreproducible

    On Tue, 2 Jun 2020 20:42:03 +0100 Samuel Henrique <samueloph@debian.org> wrote:
    The "--extra-package" option only works if an absolute path is passed, that is confusing as generally speaking command line tools don't have issues with relative paths (when they do, it's called out in the docs).

    I looked at the source code of sbuild to see if I could provide a
    patch for it but unfortunately I don' t work with perl and I lack the
    time to learn it for this right now.

    So this is a feature request to make "extra-package" accept relative
    paths as input.

    FWIW this is the input that didn't work: "--extra-package=../build-area/"

    I tried this both with directories as well with plain *.deb files relative to the path where I run sbuild and it worked just fine.

    In what way are you calling sbuild that makes this not work?

    Thanks!

    cheers, josch
    --==============Y92043228946040905=MIME-Version: 1.0
    Content-Transfer-Encoding: 7bit
    Content-Description: signature
    Content-Type: application/pgp-signature; name="signature.asc"; charset="us-ascii"

    -----BEGIN PGP SIGNATURE-----

    iQIzBAABCgAdFiEElFhU6KL81LF4wVq58sulx4+9g+EFAmf2/loACgkQ8sulx4+9 g+GsPw/9H3xfc5amDcXx3Jcbfp7SJ5EeoRPGP+u0W8YZjYZlSj/zBWzMUw3f+iu7 oMIOR0+RtH5T2IYbr4knRFsEQMNmzdssFv6q4D/yXxfQgMYlCzL14oJce2wWymPh a8P9rlg+fSERNdWcxyCWvQ10mVWMDzpWl9sErblvc5rs4tX80okzsokHuu374c4m iGG9XzJAIBxehx0S25KPHHU15INbA0tz+84Gbq/7ZR8e4QABFZ8eVYJp6CSHl8K7 7z2xKaazbHj+XSGGLTFueNjTKU7bMjknXShVzkgppwS3D+z53qK3oTvHrgoJbQUx J3nAzzgikH18mQ6wIV46uMHapdo9QTgh1LpyyFFVkuOjqbMye4aGQTxipGBMO/C9 yoicxLDjaZB8GJH4R012ZC4fiLtQkw/4AswG4dAaeSWCyIdKiwQ6pfNXNnGNWYY4 U5C0lYwI/FURo3TKS5Lo5eEFCpHke8VoHJSiUw8oAFMtGgAhsLBQ2qVuUmS9EffZ gKufQp2ItFd0d7vl4pABWYG+H8v5Cx4FtNhf411XL75wxLwt4zUOJgNCabnOid7e xLL2a1xWKddZOZbWbeGZ3cs1xB9fkQ9nxTSE3Jh+IybGcdlAoJ7a6tl6jr6p9n6Q SvJfmwLvLibK6fbjTPqmBxyiMZo4lrQMYtXuM7jDV+TAlhG0Ork=
    =uszA
    -----END PGP SIGNATURE-----

    --- SoupGate-Win32 v1.05
    * Origin: fsxNet Usenet Gateway (21:1/5)
  • From Carlos Henrique Lima Melara@21:1/5 to Johannes Schauer Marin Rodrigues on Fri Apr 11 19:10:01 2025
    Hi,

    On Thu, Apr 10, 2025 at 01:10:23AM +0200, Johannes Schauer Marin Rodrigues wrote:
    Control: tag -1 + unreproducible

    On Tue, 2 Jun 2020 20:42:03 +0100 Samuel Henrique <samueloph@debian.org> wrote:
    The "--extra-package" option only works if an absolute path is passed, that is confusing as generally speaking command line tools don't have issues with
    relative paths (when they do, it's called out in the docs).

    I looked at the source code of sbuild to see if I could provide a
    patch for it but unfortunately I don' t work with perl and I lack the
    time to learn it for this right now.

    So this is a feature request to make "extra-package" accept relative
    paths as input.

    FWIW this is the input that didn't work: "--extra-package=../build-area/"

    I tried this both with directories as well with plain *.deb files relative to the path where I run sbuild and it worked just fine.

    In what way are you calling sbuild that makes this not work?

    I've tested --extra-package=../../some_other_dir and it works with the
    latest version in testing. I also reported --extra-repository-key didn't
    work with relative paths, but I just tested and it seems to be working.
    Maybe both were implemented but the bug not closed (?).

    Cheers,
    Charles

    --- SoupGate-Win32 v1.05
    * Origin: fsxNet Usenet Gateway (21:1/5)