• Bug#1102644: luanti FTCBFS: fails creating /minetest

    From Helmut Grohne@21:1/5 to All on Fri Apr 11 14:20:01 2025
    Source: luanti
    Version: 5.10.0+dfsg-3
    Tags: patch upstream
    User: debian-cross@lists.debian.org
    Usertags: ftcbfs

    luanti fails to cross build from source, because it attempts to create /minetest and that happens to not work resulting in Permission denied as expected. The root cause for this is that EXECUTABLE_OUTPUT_PATH ends up
    being empty, because upstream thought that in a cross build setting it
    should be empty. As much as I can relate to that, my appreciation for
    the resulting build failure is fairly limited and I suggest discarding
    that branch. Generally speaking, cross/native differences tend to be a
    recipe for failure. Patch attached.

    Helmut

    --- luanti-5.10.0+dfsg.orig/src/CMakeLists.txt
    +++ luanti-5.10.0+dfsg/src/CMakeLists.txt
    @@ -576,12 +576,8 @@
    include_directories(${CURL_INCLUDE_DIR})
    endif()

    -
    -# When cross-compiling assume the user doesn't want to run the executable anyway,
    -# otherwise place it in <source dir>/bin/ since Luanti can only run from there.
    -if(NOT CMAKE_CROSSCOMPILING)
    - set(EXECUTABLE_OUTPUT_PATH "${CMAKE_SOURCE_DIR}/bin")
    -endif()
    +# Place the executable in <source dir>/bin/ since Luanti can only run from there.
    +set(EXECUTABLE_OUTPUT_PATH "${CMAKE_SOURCE_DIR}/bin")

    # shared object target
    add_library(EngineCommon OBJECT

    --- SoupGate-Win32 v1.05
    * Origin: fsxNet Usenet Gateway (21:1/5)
  • From Travis Wrightsman@21:1/5 to All on Wed Apr 16 17:10:02 2025
    Hi Helmut,

    I forwarded your patch to upstream, who requested changes that keep the conditional for cross-building. Maybe you'd like to comment on the pull
    request with your thoughts in case you disagree, since I am not as
    familiar with cross building as you are.

    https://github.com/luanti-org/luanti/pull/16030

    Best,
    Travis

    --- SoupGate-Win32 v1.05
    * Origin: fsxNet Usenet Gateway (21:1/5)