• Bug#1103224: libssh: FTBFS: /<>/build-openssl/tests/tests_

    From Santiago Vila@21:1/5 to All on Tue Apr 15 03:30:01 2025
    Package: src:libssh
    Version: 0.11.1-1
    Severity: serious
    Tags: ftbfs trixie sid

    Dear maintainer:

    During a rebuild of all packages in unstable, your package failed to build:

    --------------------------------------------------------------------------------
    [...]
    [ 47%] Building C object examples/CMakeFiles/libssh_scp.dir/libssh_scp.c.o
    cd /<<PKGBUILDDIR>>/build-openssl/examples && /usr/bin/cc - [too-long-redacted] UILDDIR>>/examples/libssh_scp.c
    In file included from /<<PKGBUILDDIR>>/tests/torture.h:40,
    from /<<PKGBUILDDIR>>/tests/torture.c:46: /<<PKGBUILDDIR>>/tests/torture.c: In function ‘torture_setup_create_sshd_config’:
    /<<PKGBUILDDIR>>/build-openssl/tests/tests_config.h:3:41: error: missing binary operator before token ".0p2"
    3 | #define OPENSSH_VERSION_MAJOR OpenSSH_10.0p2 Debian-1, OpenSSL 3.5.0 8 Apr 2025
    | ^~~~ /<<PKGBUILDDIR>>/tests/torture.c:760:5: note: in expansion of macro ‘OPENSSH_VERSION_MAJOR’
    760 | #if OPENSSH_VERSION_MAJOR == 8 && OPENSSH_VERSION_MINOR >= 2
    | ^~~~~~~~~~~~~~~~~~~~~ /<<PKGBUILDDIR>>/build-openssl/tests/tests_config.h:3:41: error: missing binary operator before token ".0p2"
    3 | #define OPENSSH_VERSION_MAJOR OpenSSH_10.0p2 Debian-1, OpenSSL 3.5.0 8 Apr 2025
    | ^~~~ /<<PKGBUILDDIR>>/tests/torture.c:763:6: note: in expansion of macro ‘OPENSSH_VERSION_MAJOR’
    763 | #if (OPENSSH_VERSION_MAJOR == 9 && OPENSSH_VERSION_MINOR >= 8) || OPENSSH_VERSION_MAJOR > 9
    | ^~~~~~~~~~~~~~~~~~~~~ /<<PKGBUILDDIR>>/build-openssl/tests/tests_config.h:3:41: error: missing binary operator before token ".0p2"
    3 | #define OPENSSH_VERSION_MAJOR OpenSSH_10.0p2 Debian-1, OpenSSL 3.5.0 8 Apr 2025
    | ^~~~ /<<PKGBUILDDIR>>/tests/torture.c:796:6: note: in expansion of macro ‘OPENSSH_VERSION_MAJOR’
    796 | #if (OPENSSH_VERSION_MAJOR == 9 && OPENSSH_VERSION_MINOR >= 8) || OPENSSH_VERSION_MAJOR > 9
    | ^~~~~~~~~~~~~~~~~~~~~
    /<<PKGBUILDDIR>>/examples/libssh_scp.c: In function ‘close_location’: /<<PKGBUILDDIR>>/examples/libssh_scp.c:156:17: warning: ‘ssh_scp_close’ is deprecated [-Wdeprecated-declarations]
    156 | rc = ssh_scp_close(loc->scp);
    | ^~
    In file included from /<<PKGBUILDDIR>>/examples/libssh_scp.c:22: /<<PKGBUILDDIR>>/include/libssh/libssh.h:588:31: note: declared here
    588 | SSH_DEPRECATED LIBSSH_API int ssh_scp_close(ssh_scp scp);
    | ^~~~~~~~~~~~~ /<<PKGBUILDDIR>>/examples/libssh_scp.c:162:17: warning: ‘ssh_scp_free’ is deprecated [-Wdeprecated-declarations]
    162 | ssh_scp_free(loc->scp);
    | ^~~~~~~~~~~~ /<<PKGBUILDDIR>>/include/libssh/libssh.h:590:32: note: declared here
    590 | SSH_DEPRECATED LIBSSH_API void ssh_scp_free(ssh_scp scp);
    | ^~~~~~~~~~~~ /<<PKGBUILDDIR>>/examples/libssh_scp.c: In function ‘open_location’: /<<PKGBUILDDIR>>/examples/libssh_scp.c:187:9: warning: ‘ssh_scp_new’ is deprecated [-Wdeprecated-declarations]
    187 | loc->scp = ssh_scp_new(loc->session, SSH_SCP_WRITE, loc->path);
    | ^~~
    /<<PKGBUILDDIR>>/include/libssh/libssh.h:593:35: note: declared here
    593 | SSH_DEPRECATED LIBSSH_API ssh_scp ssh_scp_new(ssh_session session, int mode, const char *location);
    | ^~~~~~~~~~~ /<<PKGBUILDDIR>>/examples/libssh_scp.c:196:9: warning: ‘ssh_scp_init’ is deprecated [-Wdeprecated-declarations]
    196 | if (ssh_scp_init(loc->scp) == SSH_ERROR) {
    | ^~
    /<<PKGBUILDDIR>>/include/libssh/libssh.h:591:31: note: declared here
    591 | SSH_DEPRECATED LIBSSH_API int ssh_scp_init(ssh_scp scp);
    | ^~~~~~~~~~~~ /<<PKGBUILDDIR>>/examples/libssh_scp.c:198:13: warning: ‘ssh_scp_free’ is deprecated [-Wdeprecated-declarations]
    198 | ssh_scp_free(loc->scp);
    | ^~~~~~~~~~~~ /<<PKGBUILDDIR>>/include/libssh/libssh.h:590:32: note: declared here
    590 | SSH_DEPRECATED LIBSSH_API void ssh_scp_free(ssh_scp scp);
    | ^~~~~~~~~~~~ /<<PKGBUILDDIR>>/examples/libssh_scp.c:213:9: warning: ‘ssh_scp_new’ is deprecated [-Wdeprecated-declarations]
    213 | loc->scp = ssh_scp_new(loc->session, SSH_SCP_READ, loc->path);
    | ^~~
    /<<PKGBUILDDIR>>/include/libssh/libssh.h:593:35: note: declared here
    593 | SSH_DEPRECATED LIBSSH_API ssh_scp ssh_scp_new(ssh_session session, int mode, const char *location);
    | ^~~~~~~~~~~ /<<PKGBUILDDIR>>/examples/libssh_scp.c:222:9: warning: ‘ssh_scp_init’ is deprecated [-Wdeprecated-declarations]
    222 | if (ssh_scp_init(loc->scp) == SSH_ERROR) {
    | ^~
    /<<PKGBUILDDIR>>/include/libssh/libssh.h:591:31: note: declared here
    591 | SSH_DEPRECATED LIBSSH_API int ssh_scp_init(ssh_scp scp);
    | ^~~~~~~~~~~~ /<<PKGBUILDDIR>>/examples/libssh_scp.c:224:13: warning: ‘ssh_scp_free’ is deprecated [-Wdeprecated-declarations]
    224 | ssh_scp_free(loc->scp);
    | ^~~~~~~~~~~~ /<<PKGBUILDDIR>>/include/libssh/libssh.h:590:32: note: declared here
    590 | SSH_DEPRECATED LIBSSH_API void ssh_scp_free(ssh_scp scp);
    | ^~~~~~~~~~~~ /<<PKGBUILDDIR>>/examples/libssh_scp.c: In function ‘do_copy’: /<<PKGBUILDDIR>>/examples/libssh_scp.c:290:13: warning: ‘ssh_scp_pull_request’ is deprecated [-Wdeprecated-declarations]
    290 | r = ssh_scp_pull_request(src->scp);
    | ^
    /<<PKGBUILDDIR>>/include/libssh/libssh.h:594:31: note: declared here
    594 | SSH_DEPRECATED LIBSSH_API int ssh_scp_pull_request(ssh_scp scp);
    | ^~~~~~~~~~~~~~~~~~~~ /<<PKGBUILDDIR>>/examples/libssh_scp.c:292:17: warning: ‘ssh_scp_deny_request’ is deprecated [-Wdeprecated-declarations]
    292 | ssh_scp_deny_request(src->scp, "Not in recursive mode");
    | ^~~~~~~~~~~~~~~~~~~~ /<<PKGBUILDDIR>>/include/libssh/libssh.h:589:31: note: declared here
    589 | SSH_DEPRECATED LIBSSH_API int ssh_scp_deny_request(ssh_scp scp, const char *reason);
    | ^~~~~~~~~~~~~~~~~~~~ /<<PKGBUILDDIR>>/examples/libssh_scp.c:296:17: warning: ‘ssh_scp_request_get_size’ is deprecated [-Wdeprecated-declarations]
    296 | size = ssh_scp_request_get_size(src->scp);
    | ^~~~
    /<<PKGBUILDDIR>>/include/libssh/libssh.h:601:34: note: declared here
    601 | SSH_DEPRECATED LIBSSH_API size_t ssh_scp_request_get_size(ssh_scp scp);
    | ^~~~~~~~~~~~~~~~~~~~~~~~ /<<PKGBUILDDIR>>/examples/libssh_scp.c:297:17: warning: ‘ssh_scp_request_get_filename’ is deprecated [-Wdeprecated-declarations]
    297 | filename = strdup(ssh_scp_request_get_filename(src->scp));
    | ^~~~~~~~ /<<PKGBUILDDIR>>/include/libssh/libssh.h:599:39: note: declared here
    599 | SSH_DEPRECATED LIBSSH_API const char *ssh_scp_request_get_filename(ssh_scp scp);
    | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~ /<<PKGBUILDDIR>>/examples/libssh_scp.c:298:17: warning: ‘ssh_scp_request_get_permissions’ is deprecated [-Wdeprecated-declarations]
    298 | mode = ssh_scp_request_get_permissions(src->scp);
    | ^~~~
    /<<PKGBUILDDIR>>/include/libssh/libssh.h:600:31: note: declared here
    600 | SSH_DEPRECATED LIBSSH_API int ssh_scp_request_get_permissions(ssh_scp scp);
    | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ /<<PKGBUILDDIR>>/examples/libssh_scp.c:313:9: warning: ‘ssh_scp_push_file’ is deprecated [-Wdeprecated-declarations]
    313 | r = ssh_scp_push_file(dest->scp, src->path, size, mode);
    | ^
    /<<PKGBUILDDIR>>/include/libssh/libssh.h:596:31: note: declared here
    596 | SSH_DEPRECATED LIBSSH_API int ssh_scp_push_file(ssh_scp scp, const char *filename, size_t size, int perms);
    | ^~~~~~~~~~~~~~~~~ /<<PKGBUILDDIR>>/examples/libssh_scp.c:320:13: warning: ‘ssh_scp_free’ is deprecated [-Wdeprecated-declarations]
    320 | ssh_scp_free(dest->scp);
    | ^~~~~~~~~~~~ /<<PKGBUILDDIR>>/include/libssh/libssh.h:590:32: note: declared here
    590 | SSH_DEPRECATED LIBSSH_API void ssh_scp_free(ssh_scp scp);
    | ^~~~~~~~~~~~ /<<PKGBUILDDIR>>/examples/libssh_scp.c:332:21: warning: ‘ssh_scp_deny_request’ is deprecated [-Wdeprecated-declarations]
    332 | ssh_scp_deny_request(src->scp, "Cannot open local file");
    | ^~~~~~~~~~~~~~~~~~~~ /<<PKGBUILDDIR>>/include/libssh/libssh.h:589:31: note: declared here
    589 | SSH_DEPRECATED LIBSSH_API int ssh_scp_deny_request(ssh_scp scp, const char *reason);
    | ^~~~~~~~~~~~~~~~~~~~ /<<PKGBUILDDIR>>/examples/libssh_scp.c:339:13: warning: ‘ssh_scp_accept_request’ is deprecated [-Wdeprecated-declarations]
    339 | ssh_scp_accept_request(src->scp);
    | ^~~~~~~~~~~~~~~~~~~~~~ /<<PKGBUILDDIR>>/include/libssh/libssh.h:587:31: note: declared here
    587 | SSH_DEPRECATED LIBSSH_API int ssh_scp_accept_request(ssh_scp scp);
    | ^~~~~~~~~~~~~~~~~~~~~~ /<<PKGBUILDDIR>>/examples/libssh_scp.c:345:13: warning: ‘ssh_scp_read’ is deprecated [-Wdeprecated-declarations]
    345 | r = ssh_scp_read(src->scp, buffer, sizeof(buffer));
    | ^
    /<<PKGBUILDDIR>>/include/libssh/libssh.h:598:31: note: declared here
    598 | SSH_DEPRECATED LIBSSH_API int ssh_scp_read(ssh_scp scp, void *buffer, size_t size);
    | ^~~~~~~~~~~~ /<<PKGBUILDDIR>>/examples/libssh_scp.c:373:13: warning: ‘ssh_scp_write’ is deprecated [-Wdeprecated-declarations]
    373 | w = ssh_scp_write(dest->scp, buffer, r);
    | ^
    /<<PKGBUILDDIR>>/include/libssh/libssh.h:604:31: note: declared here
    604 | SSH_DEPRECATED LIBSSH_API int ssh_scp_write(ssh_scp scp, const void *buffer, size_t len);
    | ^~~~~~~~~~~~~ /<<PKGBUILDDIR>>/examples/libssh_scp.c:378:17: warning: ‘ssh_scp_free’ is deprecated [-Wdeprecated-declarations]
    378 | ssh_scp_free(dest->scp);
    | ^~~~~~~~~~~~ /<<PKGBUILDDIR>>/include/libssh/libssh.h:590:32: note: declared here
    590 | SSH_DEPRECATED LIBSSH_API void ssh_scp_free(ssh_scp scp);
    | ^~~~~~~~~~~~
    make[4]: *** [tests/CMakeFiles/torture.dir/build.make:96: tests/CMakeFiles/torture.dir/torture.c.o] Error 1
    make[4]: Leaving directory '/<<PKGBUILDDIR>>/build-openssl'
    make[3]: *** [CMakeFiles/Makefile2:2100: tests/CMakeFiles/torture.dir/all] Error 2
    make[3]: *** Waiting for unfinished jobs....
    [ 48%] Building C object examples/CMakeFiles/libssh_scp.dir/authentication.c.o cd /<<PKGBUILDDIR>>/build-openssl/examples && /usr/bin/cc - [too-long-redacted] DIR>>/examples/authentication.c
    [ 48%] Building C object examples/CMakeFiles/libssh_scp.dir/knownhosts.c.o
    cd /<<PKGBUILDDIR>>/build-openssl/examples && /usr/bin/cc - [too-long-redacted] UILDDIR>>/examples/knownhosts.c
    [ 49%] Building C object examples/CMakeFiles/libssh_scp.dir/connect_ssh.c.o
    cd /<<PKGBUILDDIR>>/build-openssl/examples && /usr/bin/cc - [too-long-redacted] ILDDIR>>/examples/connect_ssh.c
    [ 49%] Linking C executable libssh_scp
    cd /<<PKGBUILDDIR>>/build-openssl/examples && /usr/bin/cmake -E cmake_link_script CMakeFiles/libssh_scp.dir/link.txt --verbose=1
    /usr/bin/cc -g -O2 -Werror=implicit-function-declaration -ff [too-long-redacted] ssl/lib ../lib/libssh.so.4.10.1
    make[4]: Leaving directory '/<<PKGBUILDDIR>>/build-openssl'
    [ 49%] Built target libssh_scp
    make[3]: Leaving directory '/<<PKGBUILDDIR>>/build-openssl'
    make[2]: *** [Makefile:169: all] Error 2
    make[2]: Leaving directory '/<<PKGBUILDDIR>>/build-openssl'
    dh_auto_build: error: cd build-openssl && make -j2 "INSTALL=install --strip-program=true" VERBOSE=1 returned exit code 2
    make[1]: *** [debian/rules:23: override_dh_auto_build] Error 25
    make[1]: Leaving directory '/<<PKGBUILDDIR>>'
    make: *** [debian/rules:9: binary] Error 2
    dpkg-buildpackage: error: debian/rules binary subprocess returned exit status 2 --------------------------------------------------------------------------------

    The above is just how the build ends and not necessarily the most relevant part.
    If required, the full build log is available here:

    https://people.debian.org/~sanvila/build-logs/202504/

    About the archive rebuild: The build was made on virtual machines from AWS, using sbuild and a reduced chroot with only build-essential packages.

    If you could not reproduce the bug please contact me privately, as I
    am willing to provide ssh access to a virtual machine where the bug is
    fully reproducible.

    If this is really a bug in one of the build-depends, please use
    reassign and add an affects on src:libssh, so that this is still
    visible in the BTS web page for this package.

    Thanks.

    --- SoupGate-Win32 v1.05
    * Origin: fsxNet Usenet Gateway (21:1/5)
  • From Chris Hofstaedtler@21:1/5 to Santiago Vila on Sat Apr 19 17:10:01 2025
    Control: forwarded -1 https://git.libssh.org/projects/libssh.git/commit/?id=af10857aa3216f40c5c2e5d7116803fb03c166f9
    Control: tags -1 + upstream fixed-upstream

    On Tue, Apr 15, 2025 at 01:22:22AM +0000, Santiago Vila wrote:
    /<<PKGBUILDDIR>>/build-openssl/tests/tests_config.h:3:41: error: missing binary operator before token ".0p2"
    3 | #define OPENSSH_VERSION_MAJOR OpenSSH_10.0p2 Debian-1, OpenSSL 3.5.0 8 Apr 2025
    | ^~~~

    Probably fixed upstream with: https://git.libssh.org/projects/libssh.git/commit/?id=af10857aa3216f40c5c2e5d7116803fb03c166f9
    "CmakeLists: Fix multiple digit major version for OpenSSH"

    --- SoupGate-Win32 v1.05
    * Origin: fsxNet Usenet Gateway (21:1/5)