Package: snapclient
Version: 0.26.0+dfsg1-1~bpo11+1
Severity: normal
Tags: patch
X-Debbugs-Cc: aloo_shu@protonmail.ch

Dear Maintainer,

to reproduce, use the included conf file and start the systemwide snapclient.service

expected: service starts and runs
what happens: starts and deactivates
suspected cause: ExecStart=/usr/bin/snapclient --logsink=system $SNAPCLIENT_OPTS in snapclient.service

systemd doesn't do shell-like variable substitution, you'd need to start the process in a shell
systemd has instead has its own fixed set of %-'speciefiers' for substitution, defined in man systemd.unit
luckily, including the SNAPCLIENT_OPTS with the ExecStart= directive, is redundant, since snapclient
reads SNAPCLIENT_OPTS from its environment, and the EnvironmentFile=-/etc/default/snapclient directive
sources the environment from the conf file. Hence,

suggested patch: ExecStart=/usr/bin/snapclient --logsink=system , without the malformed variable

AFAICT, the bug affects not only this version

probably bad practice to mention two bugs in one report, but fwiw, snapclient apparantly also has a
non-robust way of managing its pidfile: running snapclient from the commandline as root once, then killing
it, can lead to Exception: Could not open PID lock file "/var/run/snapclient/pid" and failure of the
service later, alas, I'm failing to reproduce this now that I'd like to give exact steps

-- System Information:
Debian Release: 11.7
APT prefers oldstable-updates
APT policy: (501, 'oldstable-updates'), (501, 'oldstable')
Architecture: armhf (armv7l)

Kernel: Linux 5.10.0-30-rt-armmp (SMP w/2 CPU threads; PREEMPT)
Kernel taint flags: TAINT_CRAP
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8), LANGUAGE not set
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)

Versions of packages snapclient depends on:
ii adduser 3.118
ii init-system-helpers 1.60
ii libasound2 1.2.4-1.1
ii libavahi-client3 0.8-5+deb11u2
ii libavahi-common3 0.8-5+deb11u2
ii libc6 2.31-13+deb11u6
ii libflac8 1.3.3-2+deb11u1
ii libgcc-s1 10.2.1-6
ii libogg0 1.3.4-0.1
ii libopus0 1.3.1-0.1
ii libpulse0 14.2-2
ii libsoxr0 0.1.3-4
ii libstdc++6 10.2.1-6
ii libvorbis0a 1.3.7-1

Versions of packages snapclient recommends:
ii avahi-daemon 0.8-5+deb11u2

snapclient suggests no packages.

-- Configuration Files:
/etc/default/snapclient changed:
SNAPCLIENT_OPTS="--host 127.0.0.1 --logfilter=*:warning --daemon=-18"


-- debconf-show failed

--- SoupGate-Win32 v1.05
* Origin: fsxNet Usenet Gateway (21:1/5)

VXBkYXRlOiBuZWl0aGVyIGNhdXNlIG5vciBwYXRjaCB3ZXJlIGNvcnJlY3QKCnRoZSBvcHRpb24g bWFuIHNuYXBjbGllbnQgc3VnZ2VzdHMgZm9yIGNoYW5naW5nIG5pY2VuZXNzLCBpcyAtLWRhZW1v bj08bmljZSB2YWx1ZT4sIGFuZCB0aGF0J3Mgd2hhdCBJJ20gZG9pbmcgaW4gbXkgY29uZiBmaWxl LCBidXQgdGhlIHN5c3RlbWQgc2VydmljZSBpbiBpdHMgY3VycmVudCBmb3JtIGlzIG9mIHR5cGUg c2ltcGxlLCBhbmQgZXhwZWN0cyB0aGUgbWFpbiBwcm9jZXNzIHRvIHJ1biwgbm90IGZvcmsgYW5k IGRhZW1vbml6ZQoKdGhhdCdzIGZpeGFibGUgd2l0aAoKW1NlcnZpY2VdIFR5cGU9Zm9ya2luZwpO aWNlPS0yMCBFbnZpcm9ubWVudEZpbGU9LS9ldGMvZGVmYXVsdC9zbmFwY2xpZW50IEV4ZWNTdGFy dD0vdXNyL2Jpbi9zbmFwY2xpZW50IC0tbG9nc2luaz1zeXN0ZW0gLS1kYWVtb249LTMgJFNOQVBD TElFTlRfT1BUUwpbLi5dCgpsaWtlIHRoaXMsIHN5c3RlbWQgd2lsbCBhbHdheXMgcnVuIHNuYXBj bGllbnQgYXMgYSBkYWVtb24uIHBhc3NpbmcgdGhlIC0tZGFlbW9uIG9wdGlvbiBpbiB0aGUgY29u ZiBmaWxlLCBiZWNvbWVzIHNhZmUuIE5pY2U9LTIwIHdpbGwgYmUgb3ZlcnJpZGRlbiBieSAtLWRh ZW1vbj0tMyAodGhlIGRlZmF1bHQgYXMgcGVyIG1hbnBhZ2UsIGJ1dCBhbHRob3VnaCBkZXNpcmFi bGUsIGRvZXNuJ3QgaGFwcGVuKSwgYW5kIGxhdHRlciAtLWRhZW1vbj08bmljZSB2YWx1ZT4gb3B0 aW9ucyBzb3VyY2VkIGZyb20gdGhlIGNvbmYgZmlsZSwgd2lsbCBiZSBhbGxvd2VkIGFsbCB2YWx1 ZXMKCmFwcGFyYW50bHksIHN5c3RlbWQgZG9lcyB0aGUgdmFyaWFibGUgc3Vic3RpdHV0aW9uIGFm dGVyIGFsbAoKYXJndWFibHksIHNldHRpbmcgbmljZW5lc3MgaXMgYSBjb3JlIGZ1bmN0aW9uYWxp dHkgZm9yIGVuc3VyaW5nIGFuIGF1ZGlvIHN0cmVhbWluZyBzZXJ2aWNlJ3Mgc21vb3RoIGFuZCBn bGl0Y2gtbGVzcyBvcGVyYXRpb24sIHdoaWNoIGNvdWxkIHJhaXNlIHRoZSBidWcgc2V2ZXJpdHk=

PGRpdiBzdHlsZT0iZm9udC1mYW1pbHk6IEFyaWFsLCBzYW5zLXNlcmlmOyBmb250LXNpemU6IDE0 cHg7Ij48L2Rpdj48ZGl2PjxzcGFuPlVwZGF0ZTogbmVpdGhlciBjYXVzZSBub3IgcGF0Y2ggd2Vy ZSBjb3JyZWN0PC9zcGFuPjwvZGl2PjxkaXY+PGJyPjwvZGl2PjxkaXY+PHNwYW4+dGhlIG9wdGlv biBtYW4gc25hcGNsaWVudCBzdWdnZXN0cyBmb3IgY2hhbmdpbmcgbmljZW5lc3MsIGlzIC0tZGFl bW9uPSZsdDtuaWNlIHZhbHVlJmd0OywgYW5kIHRoYXQncyB3aGF0IEknbSBkb2luZyBpbiBteSBj b25mIGZpbGUsIGJ1dCB0aGUgc3lzdGVtZCBzZXJ2aWNlIGluIGl0cyBjdXJyZW50IGZvcm0gaXMg b2YgdHlwZSBzaW1wbGUsIGFuZCBleHBlY3RzIHRoZSBtYWluIHByb2Nlc3MgdG8gcnVuLCBub3Qg Zm9yayBhbmQgZGFlbW9uaXplPC9zcGFuPjwvZGl2PjxkaXY+PGJyPjwvZGl2PjxkaXY+PHNwYW4+ dGhhdCdzIGZpeGFibGUgd2l0aDwvc3Bhbj48L2Rpdj48ZGl2Pjxicj48L2Rpdj48ZGl2PjxzcGFu PltTZXJ2aWNlXSAmbmJzcDsgJm5ic3A7ICZuYnNwOyAmbmJzcDsgJm5ic3A7ICZuYnNwOyAmbmJz cDsgJm5ic3A7ICZuYnNwOyAmbmJzcDsgJm5ic3A7ICZuYnNwOyAmbmJzcDsgJm5ic3A7ICZuYnNw OyAmbmJzcDsgJm5ic3A7ICZuYnNwOyAmbmJzcDsgJm5ic3A7ICZuYnNwOyAmbmJzcDsgJm5ic3A7 ICZuYnNwOyAmbmJzcDsgJm5ic3A7ICZuYnNwOyAmbmJzcDsgJm5ic3A7ICZuYnNwOyAmbmJzcDsg Jm5ic3A7ICZuYnNwOyAmbmJzcDsgJm5ic3A7ICZuYnNwOyAmbmJzcDsgJm5ic3A7ICZuYnNwOyAm bmJzcDsgJm5ic3A7ICZuYnNwOyAmbmJzcDsgJm5ic3A7ICZuYnNwOyAmbmJzcDsgJm5ic3A7ICZu YnNwOyAmbmJzcDsgJm5ic3A7ICZuYnNwOyAmbmJzcDsgJm5ic3A7ICZuYnNwOyAmbmJzcDsgJm5i c3A7ICZuYnNwOyAmbmJzcDsgJm5ic3A7IFR5cGU9Zm9ya2luZyAmbmJzcDsgJm5ic3A7ICZuYnNw OyA8L3NwYW4+PC9kaXY+PGRpdj48c3Bhbj5OaWNlPS0yMCAmbmJzcDsgJm5ic3A7ICZuYnNwOyAm bmJzcDsgJm5ic3A7ICZuYnNwOyAmbmJzcDsgJm5ic3A7ICZuYnNwOyAmbmJzcDsgJm5ic3A7ICZu YnNwOyAmbmJzcDsgJm5ic3A7ICZuYnNwOyAmbmJzcDsgJm5ic3A7ICZuYnNwOyAmbmJzcDsgJm5i c3A7ICZuYnNwOyAmbmJzcDsgJm5ic3A7ICZuYnNwOyAmbmJzcDsgJm5ic3A7ICZuYnNwOyAmbmJz cDsgJm5ic3A7ICZuYnNwOyAmbmJzcDsgJm5ic3A7ICZuYnNwOyAmbmJzcDsgJm5ic3A7ICZuYnNw OyAmbmJzcDsgJm5ic3A7ICZuYnNwOyAmbmJzcDsgJm5ic3A7ICZuYnNwOyAmbmJzcDsgJm5ic3A7 ICZuYnNwOyAmbmJzcDsgJm5ic3A7ICZuYnNwOyAmbmJzcDsgJm5ic3A7ICZuYnNwOyAmbmJzcDsg Jm5ic3A7ICZuYnNwOyBFbnZpcm9ubWVudEZpbGU9LS9ldGMvZGVmYXVsdC9zbmFwY2xpZW50Jm5i c3A7ICZuYnNwOyAmbmJzcDsgJm5ic3A7ICZuYnNwOyAmbmJzcDsgJm5ic3A7ICZuYnNwOyAmbmJz cDsgJm5ic3A7ICZuYnNwOyAmbmJzcDsgJm5ic3A7ICZuYnNwOyAmbmJzcDsgJm5ic3A7ICZuYnNw OyAmbmJzcDsgJm5ic3A7ICZuYnNwOyAmbmJzcDsgJm5ic3A7ICZuYnNwOyAmbmJzcDsgJm5ic3A7 ICZuYnNwOyAmbmJzcDsgJm5ic3A7ICZuYnNwOyAmbmJzcDsgJm5ic3A7ICZuYnNwOyAmbmJzcDsg Jm5ic3A7IEV4ZWNTdGFydD0vdXNyL2Jpbi9zbmFwY2xpZW50IC0tbG9nc2luaz1zeXN0ZW0gLS1k YWVtb249LTMgJFNOQVBDTElFTlRfT1BUUyAmbmJzcDsgJm5ic3A7ICZuYnNwOyAmbmJzcDsgJm5i c3A7ICZuYnNwOyAmbmJzcDsgJm5ic3A7ICZuYnNwOyAmbmJzcDsgJm5ic3A7ICZuYnNwOyAmbmJz cDsgJm5ic3A7ICZuYnNwOyAmbmJzcDsgJm5ic3A7ICZuYnNwOyAmbmJzcDsgJm5ic3A7ICZuYnNw OyAmbmJzcDsgJm5ic3A7ICZuYnNwOyAmbmJzcDsgJm5ic3A7IDwvc3Bhbj48L2Rpdj48ZGl2Pjxz cGFuPlsuLl08L3NwYW4+PC9kaXY+PGRpdj48YnI+PC9kaXY+PGRpdj48c3Bhbj5saWtlIHRoaXMs IHN5c3RlbWQgd2lsbCBhbHdheXMgcnVuIHNuYXBjbGllbnQgYXMgYSBkYWVtb24uIHBhc3Npbmcg dGhlIC0tZGFlbW9uIG9wdGlvbiBpbiB0aGUgY29uZiBmaWxlLCBiZWNvbWVzIHNhZmUuIE5pY2U9 LTIwIHdpbGwgYmUgb3ZlcnJpZGRlbiBieSAtLWRhZW1vbj0tMyAodGhlIGRlZmF1bHQgYXMgcGVy IG1hbnBhZ2UsIGJ1dCBhbHRob3VnaCBkZXNpcmFibGUsIGRvZXNuJ3QgaGFwcGVuKSwgYW5kIGxh dHRlciAtLWRhZW1vbj0mbHQ7bmljZSB2YWx1ZSZndDsgb3B0aW9ucyBzb3VyY2VkIGZyb20gdGhl IGNvbmYgZmlsZSwgd2lsbCBiZSBhbGxvd2VkIGFsbCB2YWx1ZXM8L3NwYW4+PC9kaXY+PGRpdj48 YnI+PC9kaXY+PGRpdj48c3Bhbj5hcHBhcmFudGx5LCBzeXN0ZW1kIGRvZXMgdGhlIHZhcmlhYmxl IHN1YnN0aXR1dGlvbiBhZnRlciBhbGw8L3NwYW4+PC9kaXY+PGRpdj48YnI+PC9kaXY+PGRpdj48 c3Bhbj5hcmd1YWJseSwgc2V0dGluZyBuaWNlbmVzcyBpcyBhIGNvcmUgZnVuY3Rpb25hbGl0eSBm b3IgZW5zdXJpbmcgYW4gYXVkaW8gc3RyZWFtaW5nIHNlcnZpY2UncyBzbW9vdGggYW5kIGdsaXRj aC1sZXNzIG9wZXJhdGlvbiwgd2hpY2ggY291bGQgcmFpc2UgdGhlIGJ1ZyBzZXZlcml0eTwvc3Bh bj48L2Rpdj48ZGl2Pjxicj48L2Rpdj48c3Bhbj48L3NwYW4+PGRpdiBjbGFzcz0icHJvdG9ubWFp bF9zaWduYXR1cmVfYmxvY2siIHN0eWxlPSJmb250LWZhbWlseTogQXJpYWwsIHNhbnMtc2VyaWY7 IGZvbnQtc2l6ZTogMTRweDsiPjxkaXYgY2xhc3M9InByb3Rvbm1haWxfc2lnbmF0dXJlX2Jsb2Nr LXByb3RvbiI+DQogICAgPC9kaXY+DQo8L2Rpdj4NCg==

--- SoupGate-Win32 v1.05
* Origin: fsxNet Usenet Gateway (21:1/5)