1. Forum
  2. Usenet
  3. LINUX.DEBIAN.BUGS.DIST

  • Bug#1105815: git-debpush: suggest --force parameter on errors

    From Simon Josefsson@21:1/5 to All on Thu May 15 11:40:01 2025
    Package: git-debpush
    Version: 12.12

    Here is another small UX improvement idea. On errors it looks like
    this:

    jas@kaka:~/dpkg/gsasl$ git debpush -t
    git-debpush: check failed: last upload targeted unstable, now targeting experimental; might be a mistake? ('changed-suite' check)
    git-debpush: some check(s) failed; you can pass --force to ignore them jas@kaka:~/dpkg/gsasl$

    This is very close to a perfect error message but could be improved by
    1) adding keyword 'error:' so the user understands that this is what
    actually triggers the failure (rather than some unrelated warning), and
    2) suggest the --force=changed-suite explicitly to make it more
    actionable. So how about:

    git-debpush: error: check failed: last upload targeted unstable but now targeting experimental; use '--force=changed-suite' to override

    The last error line above then becomes a bit redundant and could be
    removed.

    /Simon

    -----BEGIN PGP SIGNATURE-----

    iQNTBAAWCAL7FiEEo8ychwudMQq61M8vUXIrCP5HRaIFAmgltMTCHCYAmDMEXJLO tBYJKwYBBAHaRw8BAQdACIcrZIvhrxDBkK9fV+QlTmXxo2naObDuGtw58YaxlOu0 JVNpbW9uIEpvc2Vmc3NvbiA8c2ltb25Aam9zZWZzc29uLm9yZz6IlgQTFggAPgIb AwULCQgHAgYVCAkKCwIEFgIDAQIeAQIXgBYhBLHSvRN1vst4TPT4xNc89jjFPAa+ BQJn0XQkBQkNZGbwAAoJENc89jjFPAa+BtIA/iR73CfBurG9y8pASh3cbGOMHpDZ fMAtosu6jbpO69GHAP4p7l57d+iVty2VQMsx+3TCSAvZkpr4P/FuTzZ8JZe8Brgz BFySz4EWCSsGAQQB2kcPAQEHQOxTCIOaeXAxI2hIX4HK9bQTpNVei708oNr1Klm8 qCGKiPUEGBYIACYCGwIWIQSx0r0Tdb7LeEz0+MTXPPY4xTwGvgUCZ9F0SgUJDWRm SQCBdiAEGRYIAB0WIQSjzJyHC50xCrrUzy9RcisI/kdFogUCXJLPgQAKCRBRcisI /kdFoqdMAQCgH45aseZgIrwKOvUOA9QfsmeE8GZHYNuFHmM9FEQS6AD6A4x5aYvo Y6lo98pgtw2HPDhmcCXFItjXCrV4A0GmJA4JENc89jjFPAa+wUUBAO64fbZek6FP lRK0DrlWsrjCXuLi6PUxyzCAY6lG2nhUAQC6qobB9mkZlZ0qihy1x4JRtflqFcqq T9n7iUZkCDIiDbg4BFySz2oSCisGAQQBl1UBBQEBB0AxlRumDW6nZY7A+VCfek9V pEx6PJmdJyYPt3lNHMd6HAMBCAeIfgQYFggAJgIbDBYhBLHSvRN1vst4TPT4xNc8 9jjFPAa+BQJn0XTSBQkNZGboAAoJENc89jjFPAa+0M0BAPPRq73kLnHYNDMniVBO zUdi2XeF32idjEWWfjvyIJUOAP4wZ+ALxIehis3Uw2BzGZE6ttXQ2Q+DeCJO3TPp IqaXDAAKCRBRcisI/kdFok8EAPwMxg8421oK9vgFLaJLkxFY7f99FspzueIliLZ6 dNj1/gEA0rRv4g/2iMMgwCRAtTu5JnjgNDp6EeKxe1WnldLZ2AM=
    =Yzyd
    -----END PGP SIGNATURE-----

    --- SoupGate-Win32 v1.05
    * Origin: fsxNet Usenet Gateway (21:1/5)
  • From Ian Jackson@21:1/5 to Simon Josefsson on Thu May 15 11:50:01 2025
    Simon Josefsson writes ("Bug#1105815: git-debpush: suggest --force parameter on errors"):
    git-debpush: error: check failed: last upload targeted unstable but now targeting experimental; use '--force=changed-suite' to override

    The last error line above then becomes a bit redundant and could be
    removed.

    I like this idea. I might suggest formatting it this way instead to
    try to minimise the clutter:

    git-debpush: error: check failed: last upload targeted unstable but now
    targeting experimental (--force=changed-suite to override)

    Ian.

    --
    Ian Jackson <ijackson@chiark.greenend.org.uk> These opinions are my own.

    Pronouns: they/he. If I emailed you from @fyvzl.net or @evade.org.uk,
    that is a private address which bypasses my fierce spamfilter.

    --- SoupGate-Win32 v1.05
    * Origin: fsxNet Usenet Gateway (21:1/5)
  • From Simon Josefsson@21:1/5 to All on Thu May 15 12:00:01 2025
    tor 2025-05-15 klockan 10:41 +0100 skrev Ian Jackson:
    Simon Josefsson writes ("Bug#1105815: git-debpush: suggest --force
    parameter on errors"):
    git-debpush: error: check failed: last upload targeted unstable but
    now
    targeting experimental; use '--force=changed-suite' to override

    The last error line above then becomes a bit redundant and could be removed.

    I like this idea.  I might suggest formatting it this way instead to
    try to minimise the clutter:

      git-debpush: error: check failed: last upload targeted unstable but
    now
      targeting experimental (--force=changed-suite to override)

    Perhaps make sure whitespace is around the parameter, to make
    cut'n'paste work better:

    git-debpush: error: check failed: last upload targeted unstable but now targeting experimental (use --force=changed-suite to override)

    Similar concerns is one of few UX issues I have with gbp, but I didn't
    bother to report these and cannot recall which situation it was right
    now.

    /Simon


    -----BEGIN PGP SIGNATURE-----

    iQNTBAAWCAL7FiEEo8ychwudMQq61M8vUXIrCP5HRaIFAmgluWTCHCYAmDMEXJLO tBYJKwYBBAHaRw8BAQdACIcrZIvhrxDBkK9fV+QlTmXxo2naObDuGtw58YaxlOu0 JVNpbW9uIEpvc2Vmc3NvbiA8c2ltb25Aam9zZWZzc29uLm9yZz6IlgQTFggAPgIb AwULCQgHAgYVCAkKCwIEFgIDAQIeAQIXgBYhBLHSvRN1vst4TPT4xNc89jjFPAa+ BQJn0XQkBQkNZGbwAAoJENc89jjFPAa+BtIA/iR73CfBurG9y8pASh3cbGOMHpDZ fMAtosu6jbpO69GHAP4p7l57d+iVty2VQMsx+3TCSAvZkpr4P/FuTzZ8JZe8Brgz BFySz4EWCSsGAQQB2kcPAQEHQOxTCIOaeXAxI2hIX4HK9bQTpNVei708oNr1Klm8 qCGKiPUEGBYIACYCGwIWIQSx0r0Tdb7LeEz0+MTXPPY4xTwGvgUCZ9F0SgUJDWRm SQCBdiAEGRYIAB0WIQSjzJyHC50xCrrUzy9RcisI/kdFogUCXJLPgQAKCRBRcisI /kdFoqdMAQCgH45aseZgIrwKOvUOA9QfsmeE8GZHYNuFHmM9FEQS6AD6A4x5aYvo Y6lo98pgtw2HPDhmcCXFItjXCrV4A0GmJA4JENc89jjFPAa+wUUBAO64fbZek6FP lRK0DrlWsrjCXuLi6PUxyzCAY6lG2nhUAQC6qobB9mkZlZ0qihy1x4JRtflqFcqq T9n7iUZkCDIiDbg4BFySz2oSCisGAQQBl1UBBQEBB0AxlRumDW6nZY7A+VCfek9V pEx6PJmdJyYPt3lNHMd6HAMBCAeIfgQYFggAJgIbDBYhBLHSvRN1vst4TPT4xNc8 9jjFPAa+BQJn0XTSBQkNZGboAAoJENc89jjFPAa+0M0BAPPRq73kLnHYNDMniVBO zUdi2XeF32idjEWWfjvyIJUOAP4wZ+ALxIehis3Uw2BzGZE6ttXQ2Q+DeCJO3TPp IqaXDAAKCRBRcisI/kdFos0GAQDlGAwQ+E1J5eZ5/gwKaM5z5onjKEzEIBO2Ow+K bdcXZgEAqg+5BppdksB498jLSmaYvwGUHvsV6BrCtP/oxlsEmQU=
    =h4kz
    -----END PGP SIGNATURE-----

    --- SoupGate-Win32 v1.05
    * Origin: fsxNet Usenet Gateway (21:1/5)
  • From Sean Whitton@21:1/5 to Simon Josefsson on Sat May 17 11:10:01 2025
    Hello,

    On Thu 15 May 2025 at 11:32am +02, Simon Josefsson wrote:

    Package: git-debpush
    Version: 12.12

    Here is another small UX improvement idea. On errors it looks like
    this:

    jas@kaka:~/dpkg/gsasl$ git debpush -t
    git-debpush: check failed: last upload targeted unstable, now targeting experimental; might be a mistake? ('changed-suite' check)
    git-debpush: some check(s) failed; you can pass --force to ignore them jas@kaka:~/dpkg/gsasl$

    This is very close to a perfect error message but could be improved by
    1) adding keyword 'error:' so the user understands that this is what
    actually triggers the failure (rather than some unrelated warning), and
    2) suggest the --force=changed-suite explicitly to make it more
    actionable. So how about:

    git-debpush: error: check failed: last upload targeted unstable but now targeting experimental; use '--force=changed-suite' to override

    The last error line above then becomes a bit redundant and could be
    removed.

    I do not want git-debpush to suggest anything other than --force to the
    user in its interactive output.
    In the code there is a comment about that:

    # We don't mention the --force=check options here as those are
    # mainly for use by scripts, or when you already know what check
    # is going to fail before you invoke git-debpush. Keep the
    # script's terminal output as simple as possible. No "see the
    # manpage"!

    This is an important part of how git-debpush is trying to be different
    from dgit. Adding "error:" is fine; I'll do that.

    --
    Sean Whitton

    --=-=-Content-Type: application/pgp-signature; name="signature.asc"

    -----BEGIN PGP SIGNATURE-----

    iQJNBAEBCgA3FiEEm5FwB64DDjbk/CSLaVt65L8GYkAFAmgoT8cZHHNwd2hpdHRv bkBzcHdoaXR0b24ubmFtZQAKCRBpW3rkvwZiQLl5D/9QWhU2r+Igr5nuOg1zbAXd CDc8sjCdheuY+ssQUPvk0FMGFgpdeBVXuE7k7cvO6KdOB9junYTCxSVNsIvXOQMF 7CEjCHEjemgjlOQ/2UAM02ozAKgXrzK7pHpoXmUJqIe7YjY2/t3GdTX5GXneSUfN P8Pkbfu6eUhpjhfkFuKg8JvTJ5WeKs2F1A3rOp8AGXFOzrFxok74jKs6xrzrQWyt 4jFPP0+c9RmSgXMtbF6V1eM9Yr9R9GTenslERAaqrvf00L02D73PSahSmxk6LzwV 8R8JPptRjkqJXXiGB9zeDuo03XF5P7w/xdqUJI80VOgMBwSD+diVndbKn6TD/Br6 NT4Q9r7FlSYtTCKvGCxTRO0mKw2OfGNkTZUMzQxI/wKzitWFj3LLJaFO06PDbsPc O599dgDd8HNqVc/T4hx8NlzWW/zC07eXwgjle1Nqptp1F5btwaCDAX6Z9a5hE99T JTF/e3321kGg3Tqj3ZrnkxvLkiWEIvirGO9iKx8mPToynoSUbEjrCvwpcLrca7ob ETMSIrKuS6J0/lLV6yDAF5k5ARDX3PTKo5qXg/Hw/2d/n9kwXul3+UBPVaMT6ZEV l3quc6/yuX9SNao9p0AyovD6y05yqS6xa5B/Q14+/1nsN18YfreMjHkBH/F5eHow JEXao7DbGJzI+1tv2yKV8Q==iICk
    -----END PGP SIGNATURE-----

    --- SoupGate-Win32 v1.05
    * Origin: fsxNet Us
  • From Ian Jackson@21:1/5 to Sean Whitton on Sat May 17 13:10:02 2025
    Sean Whitton writes ("Bug#1105815: git-debpush: suggest --force parameter on errors"):
    On Thu 15 May 2025 at 11:32am +02, Simon Josefsson wrote:
    Here is another small UX improvement idea. On errors it looks like
    this:

    jas@kaka:~/dpkg/gsasl$ git debpush -t
    git-debpush: check failed: last upload targeted unstable, now targeting experimental; might be a mistake? ('changed-suite' check)
    git-debpush: some check(s) failed; you can pass --force to ignore them jas@kaka:~/dpkg/gsasl$

    This is very close to a perfect error message but could be improved by
    1) adding keyword 'error:' so the user understands that this is what actually triggers the failure (rather than some unrelated warning), and
    2) suggest the --force=changed-suite explicitly to make it more
    actionable. So how about:

    I think what Sean's reply is saying is: the messages, taken together,
    *are* actionable - they say "please pass --force".

    So maybe "error:" should be added to that line, rather than the check
    failed line.

    While thinking about this it occurred to me that we could make
    git-debpush prompt for confirmation. Sean, IDK if you like that idea.

    Ian.

    --
    Ian Jackson <ijackson@chiark.greenend.org.uk> These opinions are my own.

    Pronouns: they/he. If I emailed you from @fyvzl.net or @evade.org.uk,
    that is a private address which bypasses my fierce spamfilter.

    --- SoupGate-Win32 v1.05
    * Origin: fsxNet Usenet Gateway (21:1/5)
  • From Sean Whitton@21:1/5 to Ian Jackson on Sun May 18 13:50:01 2025
    Hello,

    On Sat 17 May 2025 at 12:07pm +01, Ian Jackson wrote:

    While thinking about this it occurred to me that we could make
    git-debpush prompt for confirmation. Sean, IDK if you like that idea.

    I think it could work. I'll experiment.

    --
    Sean Whitton

    --=-=-Content-Type: application/pgp-signature; name="signature.asc"

    -----BEGIN PGP SIGNATURE-----

    iQJNBAEBCgA3FiEEm5FwB64DDjbk/CSLaVt65L8GYkAFAmgpx1gZHHNwd2hpdHRv bkBzcHdoaXR0b24ubmFtZQAKCRBpW3rkvwZiQKAKD/451P/Q8OHEFojvSTyZxikT e0XJBpSezB+TJPEWK2ht2XGkWHmkuRV1l13re6ywZ2hm6xo1uTs2Ia55MtMiJOov 3awroCFRSpu6a5F0r79ifOm/6LMkt6yHPn+f0cIehMQp95XtOkhlNKepz0WFKHL9 IgXh3QK4q8uGVxJccW52iHon93sdwgrY6lL1CYUZz4wmvvrW+ekhOolCido9aUeU 6K8kGxqEgLaqsSjiA5BT/FfhHLCuN+0NZNNf4Ci3eHIczbkC6Ztt2IW5cATOVHfa HnDbv4upQYYXGg9ak3aSs/hZURRIyFQWRYvFvtHES7KQ7IBnpjcxzhMI8c0xubGj Q7sM5EHNFQfXeN+yZxkD2bxfXwsrJNEBlIH3OGS3mHXxTGtM5HJ4xQB8gOlkDe0E /cljNsHy0aJ5f6imKG/y4CvyPhwFIBdHj74Z5NUWm65VgJQu13trGZSMCb2p4k6A rfjEbSwnED0ErfAxP6Qpk67emkv9KFiCeII+R1KkM5ovfyrxfJUiRmLJhn7rS9h/ x+I7qMQGanzsY+OAFGomKMggy6jRR/g6Mi56jnOsVHegvRtkcExTNDOXn06BhsEg Vqw2ERGCa201kcW5D6Zkai+xjWUg6svQWAR+t7ti2Wec8ZlBbaswL0y2iCtAWXAK SKvRebE6vdRNYZApKwzplA=;2X
    -----END PGP SIGNATURE-----

    --- SoupGate-Win32 v1.05
    * Origin: fsxNet Usen