1. Forum
  2. Usenet
  3. LINUX.GENTOO.DEV

  • Re: [gentoo-dev] [PATCH] cmake.eclass: Fix MYCMAKEARGS breakage with >=

    From Ionen Wolkens@21:1/5 to Ionen Wolkens on Wed Feb 16 23:30:02 2022
    On Wed, Feb 16, 2022 at 05:21:29PM -0500, Ionen Wolkens wrote:
    Better fix would've been to remove the quotes I think, so that it
    splits arguments and doesn't pass a literal empty "" string.

    Although I guess it is a behavior change, so may prefer to wait for
    EAPI change.

    ..but given ebuilds relying on this is a bug, I think that'd be the
    ebuild's own problem and there's no need to care about it.

    --
    ionen

    -----BEGIN PGP SIGNATURE-----

    iQEzBAABCAAdFiEEx3SLh1HBoPy/yLVYskQGsLCsQzQFAmINejQACgkQskQGsLCs QzSN5wgAsMgstBx9HWpTs3dQjoTAaM4mIlBxJe4U5IORGDcLQ6o/MuzqWI+QHHJ7 mZf7yBrixW4jUnmxdVmY62BA2RXvDEhD3G6669YeV5c1X/mVb5JGvvSdQss8tBOg XJ3FGqnUUvPKDoXFQg8G2kBJgpEUPZk43SiAHlH+w82AsqbfQafDebZnNFb6gbD2 luK/4EzFYDS68COJwe/HJPMFySI17fxnd2GYaeCH7Wj+VNFz4GOyMgx6vwIOd7FN NED+rvI4KSBWFcRja35dE8hIrTSV78nNIUNdQD7BT0ksIQBE+6kqCS5nwFN2uukC 6v6ZrZk/DoMZEgRpMKZ9paDEqSydrQ==
    =pc8g
    -----END PGP SIGNATURE-----

    --- SoupGate-Win32 v1.05
    * Origin: fsxNet Usenet Gateway (21:1/5)
  • From Ionen Wolkens@21:1/5 to Andreas Sturmlechner on Wed Feb 16 23:30:02 2022
    On Wed, Feb 16, 2022 at 06:58:20PM +0100, Andreas Sturmlechner wrote:
    I'm not sure what this variable is about, but we gotta fix it.

    Mentioned this in the bug too, but it's like MYMESONARGS and
    EXTRA_ECONF. Not documented but it's still spread around by
    word of mouth and sometime used by devs too when asking users
    to try options ("does it work with MYCMAKEARGS=-DFIX emerge ...")

    Any ebuilds using it directly (e.g. pcsx2) is a bug.

    ...and rather drop on next EAPI bump.

    May result in some annoyed users that will ask for it back, not
    that I think the use is that widespread unlike EXTRA_ECONF.

    - "${MYCMAKEARGS}"
    )

    + if [[ -n ${MYCMAKEARGS} ]] ; then
    + cmakeargs+=( "${MYCMAKEARGS}" )
    + fi
    +

    Better fix would've been to remove the quotes I think, so that it
    splits arguments and doesn't pass a literal empty "" string.

    i.e. users could MYCMAKEARGS="-DARG1=yes -DARG2=no" through package.env

    --
    ionen

    -----BEGIN PGP SIGNATURE-----

    iQEzBAABCAAdFiEEx3SLh1HBoPy/yLVYskQGsLCsQzQFAmINeOkACgkQskQGsLCs QzSX9AgAs73SilFaDlRs2R0My/SmYhtAkI0dLsPWVNoORoeD9ebtfAAzO0txbf9g FacwV+Wwh7JvdrISJ3xyLWBXU9Twt1DRdu9zSYzls/CmD89saZyXYHdn0b0AVF3p D/MQDga36rdPhnqVL6tfuZ2Qp4Uoghc7qinYrI+PS/5oJYNd8Z/Heubj3qgxzMs0 aHwtLzWjtO7Uf6L/YXZpj/PHs0UemdsREE/MKKvZuYfjbcSRn4DulqsR+paKdzZD bKgWJVEfJ3+gUPOMHTLqTxMtXXYE0ekr0BVQi2uLnulnByeyGVffcKATgB27M0/Y pyEtSf77OyqjhsOd34gTWo+H8OprUg==
    =siaq
    -----END PGP SIGNATURE-----

    --- SoupGate-Win32 v1.05
    * Origin: fsxNet Usenet Gateway (21:1/5)