1. Forum
  2. Usenet
  3. LINUX.GENTOO.DEV

  • [gentoo-dev] [PATCH v5 3/9] vim-plugin.eclass: EAPI 8: install allowed

    From Anna Vyalkova@21:1/5 to All on Mon Apr 11 14:40:01 2022
    Signed-off-by: Anna Vyalkova <cyber+gentoo@sysrq.in>
    ---
    eclass/vim-plugin.eclass | 39 ++++++++++++++++++++++++++++++++-------
    1 file changed, 32 insertions(+), 7 deletions(-)

    diff --git a/eclass/vim-plugin.eclass b/eclass/vim-plugin.eclass
    index a457f3a037..0c323e0d09 100644
    --- a/eclass/vim-plugin.eclass
    +++ b/eclass/vim-plugin.eclass
    @@ -1,167 +1,192 @@
    # Copyright 1999-2022 Gentoo Authors
    # Distributed under the terms of the GNU General Public License v2

    # @ECLASS: vim-plugin.eclass
    # @MAINTAINER:
    # vim@gentoo.org
    # @SUPPORTED_EAPIS: 6 7 8
    # @BLURB: used for installing vim plugins
    # @DESCRIPTION:
    # This eclass simplifies installation of app-vim plugins into
    # /usr/share/vim/vimfiles. This is a version-independent directory
    # which is read automatically by vim. The only exception is
    # documentation, for which we make a special case via vim-doc.eclass.

    case ${EAPI} in
    6|7|8) ;;
    *) die "${ECLASS}: EAPI ${EAPI:-0} not supported" ;;
    esac

    if [[ ! ${_VIM_PLUGIN_ECLASS} ]]; then

    inherit vim-doc

    VIM_PLUG
  • From Thomas Bracht Laumann Jespersen@21:1/5 to All on Mon Apr 11 15:00:01 2022
    + case ${EAPI:-0} in
    + 6|7)
    + for d in *; do
    + [[ -d "${d}" ]] || continue
    + doins -r "${d}"
    + done ;;
    + *)
    + for d in "${_VIM_PLUGIN_ALLOWED_DIRS[@]}" "${@}"; do
    + [[ -d "${d}" ]] || continue
    + doins -r "${d}"
    + done ;;
    + esac

    Could you use "8)" instead of "*)" here? There should only be 6, 7, and 8 to handle here.

    --- SoupGate-Win32 v1.05
    * Origin: fsxNet Usenet Gateway (21:1/5)
  • From Anna Vyalkova@21:1/5 to Thomas Bracht Laumann Jespersen on Mon Apr 11 15:10:01 2022
    On 2022-04-11 14:51, Thomas Bracht Laumann Jespersen wrote:
    + case ${EAPI:-0} in
    + 6|7)
    + for d in *; do
    + [[ -d "${d}" ]] || continue
    + doins -r "${d}"
    + done ;;
    + *)
    + for d in "${_VIM_PLUGIN_ALLOWED_DIRS[@]}" "${@}"; do
    + [[ -d "${d}" ]] || continue
    + doins -r "${d}"
    + done ;;
    + esac

    Could you use "8)" instead of "*)" here? There should only be 6, 7, and 8 to handle here.

    Other versions don't pass the EAPI guard. Also this solution is
    more future-proof.

    --- SoupGate-Win32 v1.05
    * Origin: fsxNet Usenet Gateway (21:1/5)