• [gentoo-dev] [PATCH 09/11] net-wireless/blueman: Invoke eautomake to fi

    From =?UTF-8?q?Micha=C5=82=20G=C3=B3rny?@21:1/5 to All on Fri Jul 29 12:40:01 2022
    Signed-off-by: Michał Górny <mgorny@gentoo.org>
    ---
    net-wireless/blueman/blueman-2.3.1.ebuild | 2 +-
    net-wireless/blueman/blueman-9999.ebuild | 2 +-
    2 files changed, 2 insertions(+), 2 deletions(-)

    diff --git a/net-wireless/blueman/blueman-2.3.1.ebuild b/net-wireless/blueman/blueman-2.3.1.ebuild
    index dbedcfc7eae6..997963609ec2 100644
    --- a/net-wireless/blueman/blueman-2.3.1.ebuild
    +++ b/net-wireless/blueman/blueman-2.3.1.ebuild
    @@ -97,7 +97,7 @@ pkg_setup() {
    }

    src_prepare() {
    - [[ ${PV} == 9999 ]] && eautoreconf
    + [[ ${PV} == 9999 ]] && eautoreconf || eautomake
    distutils-r1_src_prepare
    }

    diff --git a/net-wireless/blueman/blueman-9999.ebuild b/net-wireless/blueman/blueman-9999.ebuild
    index dbedcfc7eae6..997963609ec2 100644
    --- a/net-wireless/blueman/blueman-9999.ebuild
    +++ b/net-wireless/blueman/blueman-9999.ebuild
    @@ -97,7 +97,7 @@ pkg_setup() {
    }

    src_prepare() {
    - [[ ${PV} == 9999 ]] && eautoreconf
    + [[ ${PV} == 9999 ]] && eautoreconf || eautomake
    distutils-r1_src_prepare
    }

    --
    2.35.1

    --- SoupGate-Win
  • From Ulrich Mueller@21:1/5 to All on Fri Jul 29 15:00:06 2022
    On Fri, 29 Jul 2022, Michał Górny wrote:

    --- a/net-wireless/blueman/blueman-2.3.1.ebuild
    +++ b/net-wireless/blueman/blueman-2.3.1.ebuild
    @@ -97,7 +97,7 @@ pkg_setup() {
    }

    src_prepare() {
    - [[ ${PV} == 9999 ]] && eautoreconf
    + [[ ${PV} == 9999 ]] && eautoreconf || eautomake

    So if eautoreconf returns with nonzero status, eautomake will be called?
    Or does eautoreconf always return zero (I believe it does)?

    However, I don't want to think about that when reading the code, so
    could you make it an if-then-else statement instead?

    Same for the live ebuild.

    Ulrich

    --=-=-Content-Type: application/pgp-signature; name="signature.asc"

    -----BEGIN PGP SIGNATURE-----

    iQFDBAEBCAAtFiEEtDnZ1O9xIP68rzDbUYgzUIhBXi4FAmLj2Z4PHHVsbUBnZW50 b28ub3JnAAoJEFGIM1CIQV4uLeYH/jBJ8dakkQsZi0pkdRIkJgnXV/7ieDgI/8W2 1Hxp3H32nSQzzl0xgQ0swCnjh+jOLrEDkmZpZw5sUV1J8VI4dtDZTxDQcZyjX4qd yhe2PaIQOxsVpxFrwDCLakqqmg0UcrmOHkkT1Ocjx9AoIqtkBuZcoiToMkSBR6QN LfoJZs/Fi+a+XEzKVCghSS58jph+7Al+VLLSeL3Gr4UIEEO++yB3IAAyANoDSERn f49JDyVfThdCo2oQmaqSafkr8gQTzxEp/M016YRoe6e+VGVaa9n4L1bqSJVAmqYU PLpIi/6bQ5qcFQpAu+v32SbKVPw6uJMxzhlllLCEknsgamvKxXk=aS8P
    -----END PGP SIGNATURE-----

    --- SoupGate-Win32 v1.05
    * Origin: fsxNet Usenet Gateway (21:1/5)