• [gentoo-dev] [PATCH] metadata/install-qa-check.d: add 60noop-testsuites

    From matoro@21:1/5 to All on Mon Aug 15 00:10:01 2022
    This attempts to catch autotools-based tests that will pass without
    actually executing any tests due to automagic-based rules like the presence/absence of a dependency.

    Bug: https://bugs.gentoo.org/848579
    ---
    metadata/install-qa-check.d/60noop-testsuites | 28 +++++++++++++++++++
    1 file changed, 28 insertions(+)
    create mode 100644 metadata/install-qa-check.d/60noop-testsuites

    diff --git a/metadata/install-qa-check.d/60noop-testsuites b/metadata/install-qa-check.d/60noop-testsuites
    new file mode 100644
    index 0000000000..82e3de6b7e
    --- /dev/null
    +++ b/metadata/install-qa-check.d/60noop-testsuites
    @@ -0,0 +1,28 @@
    +# Copyright 2021-2022 Gentoo Authors
    +# Distributed under the terms of the GNU General Public License v2
    +
    +# QA check: look for autotools-based tests are actually no-ops
    +# Maintainer: Quality Assurance team <qa@gentoo.org>
    +
    +noop_testsuite_check() {
    + use test || return
    +
    + IFS= readarray -t noop_testsuites < <(find "${S}" -type f -name 'test-suite.log' -print0 | xargs -0 grep -l "TOTAL: 0" 2>/dev/null)
    +
    + if [[ -n ${noop_testsuites[@]} ]]; then
    + eqawarn "QA Notice: Test suite passed but did not actually
    execute any tests:"
    + eqawarn
    +