1. Forum
  2. Usenet
  3. LINUX.GENTOO.DEV

  • [gentoo-dev] [PATCH] unpacker.eclass: enable EAPI 8

    From Stephan Hartmann@21:1/5 to All on Thu Aug 26 12:20:01 2021
    Signed-off-by: Stephan Hartmann <sultan@gentoo.org>
    ---
    eclass/unpacker.eclass | 4 ++--
    1 file changed, 2 insertions(+), 2 deletions(-)

    diff --git a/eclass/unpacker.eclass b/eclass/unpacker.eclass
    index c9dab4345c9..424975ba8ba 100644
    --- a/eclass/unpacker.eclass
    +++ b/eclass/unpacker.eclass
    @@ -4,7 +4,7 @@
    # @ECLASS: unpacker.eclass
    # @MAINTAINER:
    # base-system@gentoo.org
    -# @SUPPORTED_EAPIS: 5 6 7
    +# @SUPPORTED_EAPIS: 5 6 7 8
    # @BLURB: helpers for extraneous file formats and consistent behavior across EAPIs
    # @DESCRIPTION:
    # Some extraneous file formats are not part of PMS, or are only in certain
    @@ -16,7 +16,7 @@
    # - support partial unpacks?

    case ${EAPI:-0} in
    - [567]) ;;
    + [5678]) ;;
    *) die "${ECLASS}: EAPI ${EAPI:-0} not supported" ;;
    esac

    --
    2.31.1

    --- SoupGate-Win32 v1.05
    * Origin: fsxNet Usenet Gateway (21:1/5)
  • From Ulrich Mueller@21:1/5 to All on Thu Aug 26 13:50:01 2021
    On Thu, 26 Aug 2021, Stephan Hartmann wrote:

    --- a/eclass/unpacker.eclass
    +++ b/eclass/unpacker.eclass
    @@ -4,7 +4,7 @@
    # @ECLASS: unpacker.eclass
    # @MAINTAINER:
    # base-system@gentoo.org
    -# @SUPPORTED_EAPIS: 5 6 7
    +# @SUPPORTED_EAPIS: 5 6 7 8
    # @BLURB: helpers for extraneous file formats and consistent behavior across EAPIs
    # @DESCRIPTION:
    # Some extraneous file formats are not part of PMS, or are only in certain @@ -16,7 +16,7 @@
    # - support partial unpacks?

    case ${EAPI:-0} in
    - [567]) ;;
    + [5678]) ;;
    *) die "${ECLASS}: EAPI ${EAPI:-0} not supported" ;;
    esac


    I think for EAPI 8 you'll need additional cases in _unpacker() for
    7z, .rar, and .lha/.lzh, because package manager support for these
    extensions has been dropped: https://projects.gentoo.org/pms/8/pms.html#x1-135002r24

    Ulrich

    --=-=-Content-Type: application/pgp-signature; name="signature.asc"

    -----BEGIN PGP SIGNATURE-----

    iQFDBAEBCAAtFiEEtDnZ1O9xIP68rzDbUYgzUIhBXi4FAmEnfbcPHHVsbUBnZW50 b28ub3JnAAoJEFGIM1CIQV4uShAH/R0me/+49eDrDigWVy2Rhj/Enj6D2JymJKQt zkyTOba5rzn6oByuIUtK9i1a0yPIiOE96Hlijl/GPei1fdixI8LUFVEfONoSFfcW FNMsZ5XBCO8ESEftJg0c2wCT4ZNMa1FAGOPgD4Vri0bXyw3X5C5doneWKmPldtjd W/jl80FP7JDr8GhLwcjpTofMgNh24eY1lgQReWZwVF0Rl3kXbLrhHOACTcj0drIa Ttzs4S2rKU3hFofc2KJkPDJU2MEH09zWt1/OUwJMeHThOqhcHOrMaICnhClnOWP0 dRnsPRPusjcP0bTdflsfg0LE1c9m978G8okRxS8u9o2f8VTKFuMåSO
    -----END PGP SIGNATURE-----

    --- SoupGate-Win32 v1.05
    * Origin: fsxNet Usenet Gateway (21:1/5)
  • From Mike Gilbert@21:1/5 to ulm@gentoo.org on Thu Aug 26 17:50:01 2021
    On Thu, Aug 26, 2021 at 7:40 AM Ulrich Mueller <ulm@gentoo.org> wrote:

    On Thu, 26 Aug 2021, Stephan Hartmann wrote:

    --- a/eclass/unpacker.eclass
    +++ b/eclass/unpacker.eclass
    @@ -4,7 +4,7 @@
    # @ECLASS: unpacker.eclass
    # @MAINTAINER:
    # base-system@gentoo.org
    -# @SUPPORTED_EAPIS: 5 6 7
    +# @SUPPORTED_EAPIS: 5 6 7 8
    # @BLURB: helpers for extraneous file formats and consistent behavior across EAPIs
    # @DESCRIPTION:
    # Some extraneous file formats are not part of PMS, or are only in certain @@ -16,7 +16,7 @@
    # - support partial unpacks?

    case ${EAPI:-0} in
    - [567]) ;;
    + [5678]) ;;
    *) die "${ECLASS}: EAPI ${EAPI:-0} not supported" ;;
    esac


    I think for EAPI 8 you'll need additional cases in _unpacker() for
    7z, .rar, and .lha/.lzh, because package manager support for these
    extensions has been dropped: https://projects.gentoo.org/pms/8/pms.html#x1-135002r24

    That would be a nice enhancement for the eclass, but I don't think it
    needs to be implemented before EAPI 8 is allowed. It could wait until
    some EAPI 8 ebuild actually needs to unpack one of these obscure
    formats.

    --- SoupGate-Win32 v1.05
    * Origin: fsxNet Usenet Gateway (21:1/5)
  • From Stephan Hartmann@21:1/5 to Mike Gilbert on Thu Aug 26 20:20:01 2021
    On 8/26/21 5:43 PM, Mike Gilbert wrote:
    On Thu, Aug 26, 2021 at 7:40 AM Ulrich Mueller <ulm@gentoo.org> wrote:

    On Thu, 26 Aug 2021, Stephan Hartmann wrote:

    --- a/eclass/unpacker.eclass
    +++ b/eclass/unpacker.eclass
    @@ -4,7 +4,7 @@
    # @ECLASS: unpacker.eclass
    # @MAINTAINER:
    # base-system@gentoo.org
    -# @SUPPORTED_EAPIS: 5 6 7
    +# @SUPPORTED_EAPIS: 5 6 7 8
    # @BLURB: helpers for extraneous file formats and consistent behavior across EAPIs
    # @DESCRIPTION:
    # Some extraneous file formats are not part of PMS, or are only in certain
    @@ -16,7 +16,7 @@
    # - support partial unpacks?

    case ${EAPI:-0} in
    - [567]) ;;
    + [5678]) ;;
    *) die "${ECLASS}: EAPI ${EAPI:-0} not supported" ;;
    esac


    I think for EAPI 8 you'll need additional cases in _unpacker() for
    7z, .rar, and .lha/.lzh, because package manager support for these
    extensions has been dropped:
    https://projects.gentoo.org/pms/8/pms.html#x1-135002r24

    That would be a nice enhancement for the eclass, but I don't think it
    needs to be implemented before EAPI 8 is allowed. It could wait until
    some EAPI 8 ebuild actually needs to unpack one of these obscure
    formats.

    Almost implemented, just need some runtime testing. Will sent an updated
    patch tomorrow.

    --- SoupGate-Win32 v1.05
    * Origin: fsxNet Usenet Gateway (21:1/5)