1. Forum
  2. Usenet
  3. LINUX.GENTOO.DEV

  • Re: [gentoo-dev] [PATCH] linux-info.eclass: getfilevar: pass 'need-comp

    From Alexey Sokolov@21:1/5 to All on Tue Nov 29 23:30:01 2022
    29.11.2022 22:14, James Le Cuirot пишет:
    On Tue, 2022-11-29 at 13:55 -0500, Mike Gilbert wrote:
    This avoids some unnecessary Makefile logic and gives a nice speed up.

    Before the change, linux-info_pkg_setup takes 11 to 15 seconds on my
    AMD Phenom II. After, it takes 3 to 4 seconds.

    Signed-off-by: Mike Gilbert <floppym@gentoo.org>
    ---
    eclass/linux-info.eclass | 4 +++-
    1 file changed, 3 insertions(+), 1 deletion(-)

    diff --git a/eclass/linux-info.eclass b/eclass/linux-info.eclass
    index fc125b0d751..3e64cb9457a 100644
    --- a/eclass/linux-info.eclass
    +++ b/eclass/linux-info.eclass
    @@ -238,7 +238,9 @@ getfilevar() {
    # Pass dot-config=0 to avoid the config check in kernels prior to 5.4.
    [[ ${EAPI:-0} == [0123] ]] && nonfatal() { "$@"; }
    echo -e "e:\\n\\t@echo \$(${1})\\ninclude ${basefname}" | \
    - nonfatal emake -C "${basedname}" --no-print-directory M="${T}" dot-config=0 need-config= ${BUILD_FIXES} -s -f - 2>/dev/null
    + nonfatal emake -C "${basedname}" --no-print-directory M="${T}" \
    + dot-config=0 need-config= need-compiler= \
    + ${BUILD_FIXES} -s -f - 2>/dev/null

    ARCH=${myARCH}
    fi

    I'm confused. Breaking up the line makes it faster?

    It adds need-compiler= which was not there, but yeah, this is somewhat
    hidden in breaking the line

    --
    Best regards,
    Alexey "DarthGandalf" Sokolov

    --- SoupGate-Win32 v1.05
    * Origin: fsxNet Usenet Gateway (21:1/5)
  • From James Le Cuirot@21:1/5 to Mike Gilbert on Tue Nov 29 23:20:01 2022
    On Tue, 2022-11-29 at 13:55 -0500, Mike Gilbert wrote:
    This avoids some unnecessary Makefile logic and gives a nice speed up.

    Before the change, linux-info_pkg_setup takes 11 to 15 seconds on my
    AMD Phenom II. After, it takes 3 to 4 seconds.

    Signed-off-by: Mike Gilbert <floppym@gentoo.org>
    ---
    eclass/linux-info.eclass | 4 +++-
    1 file changed, 3 insertions(+), 1 deletion(-)

    diff --git a/eclass/linux-info.eclass b/eclass/linux-info.eclass
    index fc125b0d751..3e64cb9457a 100644
    --- a/eclass/linux-info.eclass
    +++ b/eclass/linux-info.eclass
    @@ -238,7 +238,9 @@ getfilevar() {
    # Pass dot-config=0 to avoid the config check in kernels prior to 5.4.
    [[ ${EAPI:-0} == [0123] ]] && nonfatal() { "$@"; }
    echo -e "e:\\n\\t@echo \$(${1})\\ninclude ${basefname}" | \
    - nonfatal emake -C "${basedname}" --no-print-directory M="${T}" dot-config=0 need-config= ${BUILD_FIXES} -s -f - 2>/dev/null
    + nonfatal emake -C "${basedname}" --no-print-directory M="${T}" \
    + dot-config=0 need-config= need-compiler= \
    + ${BUILD_FIXES} -s -f - 2>/dev/null

    ARCH=${myARCH}
    fi

    I'm confused. Breaking up the line makes it faster?

    -----BEGIN PGP SIGNATURE-----

    iQJFBAABCAAvFiEEPxcZ3tkwcedKm2a8EiZBXQDdMTcFAmOGhFQRHGNoZXdpQGdl bnRvby5vcmcACgkQEiZBXQDdMTeQIg//S4lJKc3f6/30oowbis2Cu3yUf9uWQNnA cSEqHZQv8RHqkjAB2zRpAe4VghcdI/J+gO3OloUtXLglgGIATPQs4FQ7zeGlpzdV TX/vDmHAnm5GtnQ+1IJ1Xz3CspM48neQsP9vutLwHxP/MnG25Nf15kA7Nd7uy7cF j8MlZO71PJzroZ/tA8NPSn9V/BHRmOZDbXl+2AnkH5gNnkg+Z8sxJkYimrmqs4tk rxMqI7MsCn8ysx/h15st3Ud1yQxdMF0nra4XoE/yf8bk5ZstMpaL7rJ4L/g/ixv8 KBvlx54WG5T75JEjsRfR5cD7Q6YpvZs2jn/kRnaOyPu7fdzd+JEIo3OU0A1qh24O OetJq6M37UkcVGOLvC3rgdq9Od3rrFg2gLOThmRH0lRbRUZpZIVQo3BwTT7UZIKw ke0/SIeAh299SuelUIx79ZM2tgF3I+ww/4wPUDi/eyjpsL/OibVGdXbfSCahHx94 gP5Goy2es6iY+ZbCxDd/YA2Th/o3tVC85xXz/wnU0RJwzQiQywIo7RWrNSP0TvE6 K4pk9Fe0Mb3TBoJekp6XmlT7kcyPD/YfT2GG1fndmO++LRvCUu7BEam07fvPA6+8 yINkejHUWCGYvzrCDYHgAZbi8mtd/fCVFeMbFJBT7oHvVnOSfhZpbybeHR5Jft3H
    az2DWGLikRA=
    =zkT7
    -----END PGP SIGNATURE-----

    --- SoupGate-Win32 v1.05
    * Origin: fsxNet Usenet Gateway (21:1/5)
  • From James Le Cuirot@21:1/5 to Mike Gilbert on Tue Nov 29 23:40:01 2022
    On Tue, 2022-11-29 at 17:31 -0500, Mike Gilbert wrote:
    On Tue, Nov 29, 2022 at 5:14 PM James Le Cuirot <chewi@gentoo.org> wrote:

    On Tue, 2022-11-29 at 13:55 -0500, Mike Gilbert wrote:
    This avoids some unnecessary Makefile logic and gives a nice speed up.

    Before the change, linux-info_pkg_setup takes 11 to 15 seconds on my
    AMD Phenom II. After, it takes 3 to 4 seconds.

    Signed-off-by: Mike Gilbert <floppym@gentoo.org>
    ---
    eclass/linux-info.eclass | 4 +++-
    1 file changed, 3 insertions(+), 1 deletion(-)

    diff --git a/eclass/linux-info.eclass b/eclass/linux-info.eclass
    index fc125b0d751..3e64cb9457a 100644
    --- a/eclass/linux-info.eclass
    +++ b/eclass/linux-info.eclass
    @@ -238,7 +238,9 @@ getfilevar() {
    # Pass dot-config=0 to avoid the config check in kernels prior to 5.4.
    [[ ${EAPI:-0} == [0123] ]] && nonfatal() { "$@"; }
    echo -e "e:\\n\\t@echo \$(${1})\\ninclude ${basefname}" | \ - nonfatal emake -C "${basedname}" --no-print-directory M="${T}" dot-config=0 need-config= ${BUILD_FIXES} -s -f - 2>/dev/null
    + nonfatal emake -C "${basedname}" --no-print-directory M="${T}" \
    + dot-config=0 need-config= need-compiler= \
    + ${BUILD_FIXES} -s -f - 2>/dev/null

    ARCH=${myARCH}
    fi

    I'm confused. Breaking up the line makes it faster?

    The change is stated in the email subject.

    Heh, sorry. I need more sleep.

    -----BEGIN PGP SIGNATURE-----

    iQJFBAABCAAvFiEEPxcZ3tkwcedKm2a8EiZBXQDdMTcFAmOGiSoRHGNoZXdpQGdl bnRvby5vcmcACgkQEiZBXQDdMTeJSw//RuhNUSZoP2AajcFj4K/l8zLHicjl/LQ3 Pd4dOnzM4hgAgsxVINLtmdLwI1QJwwijYrI+nd7Ksf+QtgYRkteahDvhaTyFIYRy KuFGiJx/QvhdyxCbuIkP+77S7D5Iqq/t4Gz2paU+EI3y9NrQPV/TNUlCNGwpcf/P EBl+XhPcFTWveF3Z9rZIkYQ9Ta3LTjKr8UvCRuYZweax7IRxsJTQXeD+AaFuBAIL S2wz/q/p9xseBCoxqOSJds1MQWAoI6fxQIPUPb2lczObMqT6ncE5y7k1dFsCsdDB B2fZide3mofQVUegUESgBdpAM8eO+p79rzGFCzyNA/GqQW2vYTPJYhSy1xjSJrnc X/+x98hP7/kcJAYErtdQkrA4q4kGMzz4PessQN207r0Ke/yREAHmY2Y+WeTw85ap UR8FWzdh+o5ttF7H4WaDTRdSyCykBLHqMR8j0Ssf9bF28yZWiiKw3Rx2PZoEo1xY PTT6I/zdEDc8lPpDDmz812rtcXSG/bwPVNHY2yEQi2C/2o/zkYKN2i9zwKKeUnNO RMjYUOTVdvZi7hgVRmM7m8MRXlEFR3oX2Rhj2WqFCvNgpJZoppPinRv1WCFlXD5/ 1Noln2foCehE8kq4HxXaNk6zMs1KnXpPj0PxrfnFv2ZYFViDVcw90FuUk+Q/j9M2
    YwFC/hIaSus=
    =Qbc6
    -----END PGP SIGNATURE-----

    --- SoupGate-Win32 v1.05
    * Origin: fsxNet Usenet Gateway (21:1/5)
  • From Mike Gilbert@21:1/5 to chewi@gentoo.org on Tue Nov 29 23:40:01 2022
    On Tue, Nov 29, 2022 at 5:14 PM James Le Cuirot <chewi@gentoo.org> wrote:

    On Tue, 2022-11-29 at 13:55 -0500, Mike Gilbert wrote:
    This avoids some unnecessary Makefile logic and gives a nice speed up.

    Before the change, linux-info_pkg_setup takes 11 to 15 seconds on my
    AMD Phenom II. After, it takes 3 to 4 seconds.

    Signed-off-by: Mike Gilbert <floppym@gentoo.org>
    ---
    eclass/linux-info.eclass | 4 +++-
    1 file changed, 3 insertions(+), 1 deletion(-)

    diff --git a/eclass/linux-info.eclass b/eclass/linux-info.eclass
    index fc125b0d751..3e64cb9457a 100644
    --- a/eclass/linux-info.eclass
    +++ b/eclass/linux-info.eclass
    @@ -238,7 +238,9 @@ getfilevar() {
    # Pass dot-config=0 to avoid the config check in kernels prior to 5.4.
    [[ ${EAPI:-0} == [0123] ]] && nonfatal() { "$@"; }
    echo -e "e:\\n\\t@echo \$(${1})\\ninclude ${basefname}" | \
    - nonfatal emake -C "${basedname}" --no-print-directory M="${T}" dot-config=0 need-config= ${BUILD_FIXES} -s -f - 2>/dev/null
    + nonfatal emake -C "${basedname}" --no-print-directory M="${T}" \
    + dot-config=0 need-config= need-compiler= \
    + ${BUILD_FIXES} -s -f - 2>/dev/null

    ARCH=${myARCH}
    fi

    I'm confused. Breaking up the line makes it faster?

    The change is stated in the email subject.

    --- SoupGate-Win32 v1.05
    * Origin: fsxNet Usenet Gateway (21:1/5)