1. Forum
  2. Usenet
  3. LINUX.GENTOO.DEV

  • [gentoo-dev] [PATCH] unpacker.eclass: Don't assume the default tar is s

    From =?UTF-8?q?Arsen=20Arsenovi=C4=87?=@21:1/5 to All on Thu Apr 6 17:40:01 2023
    Despite common misconception, the default GNU tar tarfile is not stdin.
    On some systems, this can cause tar to fail to extract relevant files.

    See '(tar)file tutorial' for a description of how the default is picked.

    Bug: https://bugs.gentoo.org/903631
    Closes: https://bugs.gentoo.org/903914
    Closes: https://bugs.gentoo.org/903919

    Signed-off-by: Arsen Arsenović <arsen@gentoo.org>
    ---
    This patch does not close https://bugs.gentoo.org/903631, as I intend to
    turn that into a tracker bug.

    eclass/unpacker.eclass | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/eclass/unpacker.eclass b/eclass/unpacker.eclass
    index 650de4bd3f75..652527b52ec6 100644
    --- a/eclass/unpacker.eclass
    +++ b/eclass/unpacker.eclass
    @@ -325,7 +325,7 @@ unpack_deb() {
    $(tc-getBUILD_AR) p "${deb}" "${f}" | ${decomp:-cat}
    assert "unpacking ${f} from ${deb} failed"
    fi
    - } | tar --no-same-owner -x
    + } | tar --no-same-owner -xf -
    assert "unpacking ${deb} failed"
    }

    --
    2.40.0

    --- SoupGate-Win32 v1.05
    * Origin: fsxNet Usenet Gateway (21:1/5)
  • From Arsen =?utf-8?Q?Arsenovi=C4=87?=@21:1/5 to arsen@gentoo.org on Thu Apr 6 17:50:01 2023
    Arsen Arsenović <arsen@gentoo.org> writes:

    Despite common misconception, the default GNU tar tarfile is not stdin.
    On some systems, this can cause tar to fail to extract relevant files.

    See '(tar)file tutorial' for a description of how the default is picked.

    Bug: https://bugs.gentoo.org/903631
    Closes: https://bugs.gentoo.org/903914
    Closes: https://bugs.gentoo.org/903919

    Signed-off-by: Arsen Arsenović <arsen@gentoo.org>
    ---
    This patch does not close https://bugs.gentoo.org/903631, as I intend to
    turn that into a tracker bug.

    Or not - amended locally to close it. See c6.

    eclass/unpacker.eclass | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/eclass/unpacker.eclass b/eclass/unpacker.eclass
    index 650de4bd3f75..652527b52ec6 100644
    --- a/eclass/unpacker.eclass
    +++ b/eclass/unpacker.eclass
    @@ -325,7 +325,7 @@ unpack_deb() {
    $(tc-getBUILD_AR) p "${deb}" "${f}" | ${decomp:-cat}
    assert "unpacking ${f} from ${deb} failed"
    fi
    - } | tar --no-same-owner -x
    + } | tar --no-same-owner -xf -
    assert "unpacking ${deb} failed"
    }


    --
    Arsen Arsenović

    --=-=-Content-Type: application/pgp-signature; name="signature.asc"

    -----BEGIN PGP SIGNATURE-----

    iOcEARYKAI8WIQT+4rPRE/wAoxYtYGFSwpQwHqLEkwUCZC7oHV8UgAAAAAAuAChp c3N1ZXItZnByQG5vdGF0aW9ucy5vcGVucGdwLmZpZnRoaG9yc2VtYW4ubmV0RkVF MkIzRDExM0ZDMDBBMzE2MkQ2MDYxNTJDMjk0MzAxRUEyQzQ5MxEcYXJzZW5AZ2Vu dG9vLm9yZwAKCRBSwpQwHqLEk5bcAQD/TYQ+zXIrjhWv2qgk9aW4UtVQDCbWjkTQ DJ7RaMb+SAEAv2Zw5vJfCldPxIFbb3ePg75SbJuY2tiaqiyWx3IXhQg=TFr3
    -----END PGP SIGNATURE-----

    --- SoupGate-Win32 v1.05
    * Origin: fsxNet Usenet Gateway (21:1/5)