• [gentoo-dev] [PATCH 03/11] ruby-ng.eclass: optimize: avoid subshell for

    From Sam James@21:1/5 to All on Thu Jun 15 18:00:01 2023
    We go from ~4s -> ~3.5s for sourcing dev-ruby/*.

    For sinatra:

    ```
    $ pk pkg source $(pkg) --repo ~/g/ --bench 5s # before dev-ruby/sinatra-2.2.3::/home/sam/g/: mean: 66.68ms, min: 56.938ms, max: 74.248ms, σ = 4.832ms, N = 75
    dev-ruby/sinatra-3.0.6::/home/sam/g/: mean: 73.618ms, min: 60.153ms, max: 77.978ms, σ = 3.195ms, N = 68
    dev-ruby/sinatra-3.0.5::/home/sam/g/: mean: 72.069ms, min: 58.736ms, max: 78.223ms, σ = 3.277ms, N = 70
    dev-ruby/sinatra-3.0.5-r1::/home/sam/g/: mean: 73.265ms, min: 60.738ms, max: 81.06ms, σ = 3.227ms, N = 69

    $ pk pkg source $(pkg) --repo ~/g/ --bench 5s # after dev-ruby/sinatra-3.0.5-r1::/home/sam/g/: mean: 59.677ms, min: 49.141ms, max: 63.282ms, σ = 2.511ms, N = 84
    dev-ruby/sinatra-3.0.6::/home/sam/g/: mean: 59.693ms, min: 48.637ms, max: 62.862ms, σ = 2.628ms, N = 84
    dev-ruby/sinatra-3.0.5::/home/sam/g/: mean: 56.697ms, min: 46.782ms, max: 60.367ms, σ = 2.822ms, N = 89
    dev-ruby/sinatra-2.2.3::/home/sam/g/: mean: 54.915ms, min: 45.832ms, max: 59.513ms, σ = 3.52ms, N = 92
    ```

    Bug: https://bugs.gentoo.org/908465
    Signed-off-by: Sam James <sam@gentoo.org>
    ---
    eclass/ruby-ng.eclass | 23 +++++++++++++----------
    1 file changed, 13 insertions(+), 10 deletions(-)

    diff --git a/eclass/ruby-ng.eclass b/eclass/ruby-ng.eclass
    index 2bf1885d38031..ee2e6b89edb41 100644
    --- a/eclass/ruby-ng.eclass
    +++ b/eclass/ruby-ng.eclass
    @@ -102,6 +102,7 @@ ruby_implementation_depend() {
    # @DESCRIPTION:
    # Return a list of valid implementations in USE_RUBY, skipping the old
    # implementations that are no longer supported.
    +_RUBY_GET_ALL_IMPLS=()
    _ruby_get_all_impls() {
    local i found_valid_impl
    for i in ${USE_RUBY}; do
    @@ -111,7 +112,8 @@ _ruby_get_all_impls() {
    ;;
    *)
    found_valid_impl=1
    - echo ${i};;
    + _RUBY_GET_ALL_IMPLS+=( ${i} )
    + ;;
    esac
    done

    @@ -131,7 +133,7 @@ ruby_samelib() {
    debug-print-function ${FUNCNAME} "${@}"

    local res=
    - for _ruby_implementation in $(_ruby_get_all_impls); do
    + for _ruby_implementation in "${_RUBY_GET_ALL_IMPLS[@]}"; do
    has -${_ruby_implementation} $@ || \
    res="${res}ruby_tar