1. Forum
  2. Usenet
  3. LINUX.GENTOO.DEV

  • [gentoo-dev] [PATCH] use.desc: Make `native-extensions` flag global

    From =?UTF-8?q?Micha=C5=82=20G=C3=B3rny?@21:1/5 to All on Sun Nov 5 06:50:01 2023
    Make the `native-extensions` flag global. It is used in 15 Python
    packages to enable building optional C extensions, though the global description also allows for other "native" and "pure" languages.

    In 9 cases, the flag description explicitly mentions "speedups", so this
    is the primary case used in global description. There is one case
    of the extension providing extra features, and the remaining cases
    do not explain its role.

    Signed-off-by: Michał Górny <mgorny@gentoo.org>
    ---
    profiles/use.desc | 1 +
    1 file changed, 1 insertion(+)

    diff --git a/profiles/use.desc b/profiles/use.desc
    index d8f97958e900..01915ae78918 100644
    --- a/profiles/use.desc
    +++ b/profiles/use.desc
    @@ -212,6 +212,7 @@ musicbrainz - Lookup audio metadata using MusicBrainz community service (musicbr
    mysql - Add mySQL Database support
    mysqli - Add support for the improved mySQL libraries
    nas - Add support for network audio sound
    +native-extensions - Build native (C, Rust) extensions in additional to pure (e.g. Python) code (usually speedups)
    ncurses - Add ncurses support (console display library)
    neXt - Enable neXt toolkit
    netcdf - Enable NetCDF data format support
    --
    2.42.1

    --- SoupGate-Win32 v1.05
    * Origin: fsxNet Usenet Gateway (21:1/5)
  • From Oskari Pirhonen@21:1/5 to All on Sun Nov 5 07:10:01 2023
    On Sun, Nov 05, 2023 at 06:42:35 +0100, Michał Górny wrote:
    Make the `native-extensions` flag global. It is used in 15 Python
    packages to enable building optional C extensions, though the global description also allows for other "native" and "pure" languages.

    In 9 cases, the flag description explicitly mentions "speedups", so this
    is the primary case used in global description. There is one case
    of the extension providing extra features, and the remaining cases
    do not explain its role.

    Signed-off-by: Michał Górny <mgorny@gentoo.org>
    ---
    profiles/use.desc | 1 +
    1 file changed, 1 insertion(+)

    diff --git a/profiles/use.desc b/profiles/use.desc
    index d8f97958e900..01915ae78918 100644
    --- a/profiles/use.desc
    +++ b/profiles/use.desc
    @@ -212,6 +212,7 @@ musicbrainz - Lookup audio metadata using MusicBrainz community service (musicbr
    mysql - Add mySQL Database support
    mysqli - Add support for the improved mySQL libraries
    nas - Add support for network audio sound
    +native-extensions - Build native (C, Rust) extensions in additional to pure (e.g. Python) code (usually speedups)

    I'd say "(e.g. C, Rust)", similarly to what you did later, so that
    people don't think it means only C or Rust extensions get built.

    - Oskari

    -----BEGIN PGP SIGNATURE-----

    iHUEABYIAB0WIQQfOU+JeXjo4uxN6vCp8he9GGIfEQUCZUcxWgAKCRCp8he9GGIf EZRpAQCMZDWKRiedMLnu6jy/qYFFT6O0EbnXmKd46US7rtT0+QD/YvyUUrq7J441 jtGNvDh0gMHR1eNsT7plC7DDpzpAhg0=
    =ucFD
    -----END PGP SIGNATURE-----

    --- SoupGate-Win32 v1.05
    * Origin: fsxNet Usenet Gateway (21:1/5)
  • From =?UTF-8?Q?Micha=C5=82_G=C3=B3rny?=@21:1/5 to Oskari Pirhonen on Sun Nov 5 13:10:01 2023
    On Sun, 2023-11-05 at 01:08 -0500, Oskari Pirhonen wrote:
    On Sun, Nov 05, 2023 at 06:42:35 +0100, Michał Górny wrote:
    Make the `native-extensions` flag global. It is used in 15 Python
    packages to enable building optional C extensions, though the global description also allows for other "native" and "pure" languages.

    In 9 cases, the flag description explicitly mentions "speedups", so this
    is the primary case used in global description. There is one case
    of the extension providing extra features, and the remaining cases
    do not explain its role.

    Signed-off-by: Michał Górny <mgorny@gentoo.org>
    ---
    profiles/use.desc | 1 +
    1 file changed, 1 insertion(+)

    diff --git a/profiles/use.desc b/profiles/use.desc
    index d8f97958e900..01915ae78918 100644
    --- a/profiles/use.desc
    +++ b/profiles/use.desc
    @@ -212,6 +212,7 @@ musicbrainz - Lookup audio metadata using MusicBrainz community service (musicbr
    mysql - Add mySQL Database support
    mysqli - Add support for the improved mySQL libraries
    nas - Add support for network audio sound
    +native-extensions - Build native (C, Rust) extensions in additional to pure (e.g. Python) code (usually speedups)

    I'd say "(e.g. C, Rust)", similarly to what you did later, so that
    people don't think it means only C or Rust extensions get built.

    Thanks, added that.

    --
    Best regards,
    Michał Górny


    -----BEGIN PGP SIGNATURE-----

    iQFGBAABCgAwFiEEx2qEUJQJjSjMiybFY5ra4jKeJA4FAmVHg8oSHG1nb3JueUBn ZW50b28ub3JnAAoJEGOa2uIyniQOM9wH/1ZQhBEtBfclZKrGv2wis1yzsM87YZAA cp73FH9n0c3kbsnThNCGGOsXw/eoJcjLURKLO/zn4s9FR+r5fe1ztY54VWVeXBq1 tYgWOXNIHUwxtiE3xy1iWFkixgwcoU60HVighF1r16jJZ4qSor1PpFyM0DX8G1DV VRFFwcj3f5AYNM4hdSE3csYiEsTcC+M79WpH3D420oZ+YyJksEKA5qOuX1Yi+0kE vVAJianQHjCFoOXp/Opfdhd+RFQ+gfyzL2b4pLrsW6M7aWqPCs1KZJNY5KhvLVT6 NyEtX+UHBMsJ3lskxb20P9ANPsTfHnqAHSIQPNcp+GOK4JqJcvSWrC8=
    =qxS4
    -----END PGP SIGNATURE-----

    --- SoupGate-Win32 v1.05
    * Origin: fsxNet Usenet Gateway (21:1/5)
  • From Eli Schwartz@21:1/5 to All on Sun Nov 5 14:50:01 2023
    On 11/5/23 1:42 AM, Michał Górny wrote:
    Make the `native-extensions` flag global. It is used in 15 Python
    packages to enable building optional C extensions, though the global description also allows for other "native" and "pure" languages.

    In 9 cases, the flag description explicitly mentions "speedups", so this
    is the primary case used in global description. There is one case
    of the extension providing extra features, and the remaining cases
    do not explain its role.


    The USE flag's name inherently feels like something aligned with
    building speedups, so why not dedicate it to that purpose? It feels
    confusing to have a global USE that does different things for different packages.

    It sounds like just renaming a single USE flag -- peewee from "native-extensions" to "sqlite-ext" -- would be enough to allow nicer
    semantics here.


    --
    Eli Schwartz

    --- SoupGate-Win32 v1.05
    * Origin: fsxNet Usenet Gateway (21:1/5)