1. Forum
  2. Usenet
  3. LINUX.GENTOO.DEV

  • [gentoo-dev] [PATCH 1/2] linux-mod-r1.eclass: Require the compression t

    From =?UTF-8?q?Micha=C5=82=20G=C3=B3rny?@21:1/5 to All on Sat Dec 30 06:10:01 2023
    Now that the module compression is conditional to USE=modules-compress,
    we no longer need to allow it to fail gracefully. If user enabled
    the compression explicitly, they expect it to succeed. If they don't
    have the tools, they can always flip it off again.

    Signed-off-by: Michał Górny <mgorny@gentoo.org>
    ---
    eclass/linux-mod-r1.eclass | 3 +--
    1 file changed, 1 insertion(+), 2 deletions(-)

    diff --git a/eclass/linux-mod-r1.eclass b/eclass/linux-mod-r1.eclass
    index 67a4b64eb481..b6be4ba8a16d 100644
    --- a/eclass/linux-mod-r1.eclass
    +++ b/eclass/linux-mod-r1.eclass
    @@ -860,9 +860,8 @@ _modules_process_compress() {
    die "USE=modules-compress enabled but no MODULE_COMPRESS* configured"
    fi

    - # could fail, assumes have commands that were needed for the kernel
    einfo "Compressing modules (matching the kernel configuration) ..."
    - edob "${compress[@]}" -- "${@}"
    + edob "${compress[@]}" -- "${@}" || die
    }

    # @FUNCTION: _modules_process_depmod.d
    --
    2.43.0

    --- SoupGate-Win32 v1.05
    * Origin: fsxNet Usenet Gateway (21:1/5)
  • From Ulrich Mueller@21:1/5 to All on Sat Dec 30 11:40:01 2023
    On Sat, 30 Dec 2023, Michał Górny wrote:

    - edob "${compress[@]}" -- "${@}"
    + edob "${compress[@]}" -- "${@}" || die

    Doesn't edob already die by itself?

    --=-=-Content-Type: application/pgp-signature; name="signature.asc"

    -----BEGIN PGP SIGNATURE-----

    iQFDBAEBCAAtFiEEtDnZ1O9xIP68rzDbUYgzUIhBXi4FAmWP8iUPHHVsbUBnZW50 b28ub3JnAAoJEFGIM1CIQV4uHooH/isLnMKWJ2qjGAKvX5nTHFFubY1/jkqHeFfP OuzRa7MPRIXyp/3kjGNMjEo6+Bkaco/WKPTug+4Eec0ScDkll4kgz+Pcp7LswqDZ ztMITwLWJAIZcZ52shsxlv+KX/dXDvvNFeBSLDsQanNMWvbGMiMmQIi2ywvLwYip ZmPFRXFO5/8/GrsENBO7e+Pk41UwA4ACHnrZFKBRl3ud4OW4LC1qFTs8lT0TS2kf 1HGqPz/2djRpNeY3NxaJIBIqh+qnoMgrMXOSjcjeP4q0O6iMpe+1CY6b8XHJayDT 7gEAX6izk7U4g2InOW7aASIzkM9LhUCQ+meNBtHzwPmMAaX2vRU=uL22
    -----END PGP SIGNATURE-----

    --- SoupGate-Win32 v1.05
    * Origin: fsxNet Usenet Gateway (21:1/5)
  • From =?UTF-8?Q?Micha=C5=82_G=C3=B3rny?=@21:1/5 to Ulrich Mueller on Sat Dec 30 14:00:01 2023
    On Sat, 2023-12-30 at 11:34 +0100, Ulrich Mueller wrote:
    On Sat, 30 Dec 2023, Michał Górny wrote:

    - edob "${compress[@]}" -- "${@}"
    + edob "${compress[@]}" -- "${@}" || die

    Doesn't edob already die by itself?

    Oh, indeed it does. I misread the comment above then. I'll withdraw
    this commit. Nevertheless, I think the other one makes sense as it
    hints people to install zstd.

    --
    Best regards,
    Michał Górny


    -----BEGIN PGP SIGNATURE-----

    iQFGBAABCgAwFiEEx2qEUJQJjSjMiybFY5ra4jKeJA4FAmWQE/kSHG1nb3JueUBn ZW50b28ub3JnAAoJEGOa2uIyniQOLTcIAIUQIE0hn3IB/BmNS6/u+PUB5O+kjIcb pRDMyMEbJopu7yjeDBpaehBxus9SI9bs8mPl4B9szEbcxLQb8jhmsqzhEXx/x+c8 s0wYKkvZ+Mu6JMaNLlCob9yNh5xGKNGEfXP/4N9hS+YmaxcwH/YXo2EhHE71BvAy qmGHXeZ+n5bAADZfe7GH1jIBK10evgX277WDtBQRxOccXvK++BT2/cZEUnJpDfYx 0klUdQSNXCL6TeuAYc3okPL91eljXUekeAlmTwXp4mAVHYkW5OoEJRw6ioT2cIu1 uZN4mKpOVXNFgDDEwg51apCCeDHoQi0giAm7zmPjdENtCH7wTiP013s=
    =rSQp
    -----END PGP SIGNATURE-----

    --- SoupGate-Win32 v1.05
    * Origin: fsxNet Usenet Gateway (21:1/5)