1. Forum
  2. Usenet
  3. LINUX.GENTOO.DEV

  • [gentoo-dev] [PATCH 1/2] gnuconfig.eclass: add GNUCONFIG_DEPEND

    From Sam James@21:1/5 to All on Fri May 3 08:50:01 2024
    The motivation here is to allow autotools.eclass consumers setting AUTOTOOLS_AUTO_DEPEND=no to not have a useless gnuconfig dependency.

    Signed-off-by: Sam James <sam@gentoo.org>
    ---
    eclass/gnuconfig.eclass | 22 +++++++++++++++++++---
    1 file changed, 19 insertions(+), 3 deletions(-)

    diff --git a/eclass/gnuconfig.eclass b/eclass/gnuconfig.eclass
    index 0791798632cdb..df3c748676082 100644
    --- a/eclass/gnuconfig.eclass
    +++ b/eclass/gnuconfig.eclass
    @@ -1,4 +1,4 @@
    -# Copyright 1999-2022 Gentoo Authors
    +# Copyright 1999-2024 Gentoo Authors
    # Distributed under the terms of the GNU General Public License v2

    # @ECLASS: gnuconfig.eclass
    @@ -24,9 +24,25 @@ esac
    if [[ -z ${_GNUCONFIG_ECLASS} ]] ; then
    _GNUCONFIG_CLASS=1

    -BDEPEND="sys-devel/gnuconfig"
    +# @ECLASS_VARIABLE: GNUCONFIG_DEPEND
    +# @OUTPUT_VARIABLE
    +# @DESCRIPTION:
    +# Contains dependency on gnuconfig in *DEPEND format. +GNUCONFIG_DEPEND="sys-devel/gnuconfig"

    -[[ ${EAPI} == [56] ]] && DEPEND="${BDEPEND}"
    +# @ECLASS_VARIABLE: GNUCONFIG_AUTO_DEPEND
    +# @PRE_INHERIT
    +# @DESCRIPTION:
    +# Set to 'no' to disable automatically adding to DEPEND. This lets
    +# ebuilds form conditional depends by using ${GNUC
  • From =?utf-8?Q?Arsen_Arsenovi=C4=87?=@21:1/5 to Sam James on Fri May 3 12:10:02 2024
    Sam James <sam@gentoo.org> writes:

    The motivation here is to allow autotools.eclass consumers setting AUTOTOOLS_AUTO_DEPEND=no to not have a useless gnuconfig dependency.

    series looks ok to me
    --
    Arsen Arsenović

    --=-=-Content-Type: application/pgp-signature; name="signature.asc"

    -----BEGIN PGP SIGNATURE-----

    iIcEARYKAC8WIQT+4rPRE/wAoxYtYGFSwpQwHqLEkwUCZjS1xhEcYXJzZW5AZ2Vu dG9vLm9yZwAKCRBSwpQwHqLEk1WqAQDod+lWZp29Bf029zXRAp03HMr7n0mG37jm yNkm2Yhi3AD/dhc777FN1BCdM/mhgrxSdI/19Pgc/UbUr/KGwsGoTQw§Us
    -----END PGP SIGNATURE-----

    --- SoupGate-Win32 v1.05
    * Origin: fsxNet Usenet Gateway (21:1/5)
  • From Ulrich Mueller@21:1/5 to All on Fri May 3 12:20:01 2024
    On Fri, 03 May 2024, Sam James wrote:

    + case ${EAPI} in
    + 5|6) DEPEND=${GNUCONFIG_DEPEND} ;;
    + *) BDEPEND=${GNUCONFIG_DEPEND} ;;
    + esac

    Drop EAPI 5 while at it?

    --=-=-Content-Type: application/pgp-signature; name="signature.asc"

    -----BEGIN PGP SIGNATURE-----

    iQFDBAEBCAAtFiEEtDnZ1O9xIP68rzDbUYgzUIhBXi4FAmY0uPgPHHVsbUBnZW50 b28ub3JnAAoJEFGIM1CIQV4uDqoH/i45iIZAeBshhQzGmFNKjlWyTAicLJeaH/Cd UdfPfakNc8SDWBhgwmSPprC0HVqHmVk0xusHontuJN2kE5V6unycNQ0bQGZJREQj kEAx2k473hZ8O6TdGzmeDru/hWr1Pr/9A1DbdhqS9fjIKlMMaOjr+V7E/vu6f0yw qZ8/2F+GNF+0J6CmnzCN/6V8ACgvnU2qH/Tx9cVTQCFnhDIFeI+UY1GGRjT3SVOX QhYgIybAZP8tcE//Ymqvkbgj5btG7fxSQYJjzMIDSFoCi1pmXBkHnC3rljzs73qN JRARWi0+PaCmP3gUeG/w2/WiVNDCGrStu8Ai9woiwCS0alqHZac=XKKM
    -----END PGP SIGNATURE-----

    --- SoupGate-Win32 v1.05
    * Origin: fsxNet Usenet Gateway (21:1/5)
  • From Sam James@21:1/5 to Ulrich Mueller on Fri May 3 13:50:01 2024
    Ulrich Mueller <ulm@gentoo.org> writes:

    On Fri, 03 May 2024, Sam James wrote:

    + case ${EAPI} in
    + 5|6) DEPEND=${GNUCONFIG_DEPEND} ;;
    + *) BDEPEND=${GNUCONFIG_DEPEND} ;;
    + esac

    Drop EAPI 5 while at it?

    Good point, done & pushed, thanks.

    --- SoupGate-Win32 v1.05
    * Origin: fsxNet Usenet Gateway (21:1/5)
  • From Sam James@21:1/5 to arsen@gentoo.org on Fri May 3 13:50:01 2024
    Arsen Arsenović <arsen@gentoo.org> writes:

    Sam James <sam@gentoo.org> writes:

    The motivation here is to allow autotools.eclass consumers setting
    AUTOTOOLS_AUTO_DEPEND=no to not have a useless gnuconfig dependency.

    series looks ok to me

    thanks!

    --- SoupGate-Win32 v1.05
    * Origin: fsxNet Usenet Gateway (21:1/5)