1. Forum
  2. Usenet
  3. LINUX.GENTOO.DEV

  • [gentoo-dev] [PATCH 1/2] linux-info.eclass: Drop temporary fix for powe

    From =?UTF-8?q?Ulrich=20M=C3=BCller?=@21:1/5 to All on Mon Jul 1 23:40:01 2024
    Apparently there is no reference to a .tmp_gas_check file or to a TOUT
    variable in Linux sources any more.

    Bug: https://bugs.gentoo.org/75034#c14
    Signed-off-by: Ulrich Müller <ulm@gentoo.org>
    ---
    eclass/linux-info.eclass | 6 ------
    1 file changed, 6 deletions(-)

    diff --git a/eclass/linux-info.eclass b/eclass/linux-info.eclass
    index 9449a6359d2a..90982445fdab 100644
    --- a/eclass/linux-info.eclass
    +++ b/eclass/linux-info.eclass
    @@ -170,12 +170,6 @@ KERNEL_DIR="${KERNEL_DIR:-${ROOT%/}/usr/src/linux}"
    inherit toolchain-funcs
    [[ ${EAPI} == 6 ]] && inherit eapi7-ver

    -# bug #75034
    -case ${ARCH} in
    - ppc) BUILD_FIXES="${BUILD_FIXES} TOUT=${T}/.tmp_gas_check";;
    - ppc64) BUILD_FIXES="${BUILD_FIXES} TOUT=${T}/.tmp_gas_check";;
    -esac
    -
    # @FUNCTION: set_arch_to_kernel
    # @DESCRIPTION:
    # Set the env ARCH to match what the kernel expects.
    --
    2.45.2

    --- SoupGate-Win32 v1.05
    * Origin: fsxNet Usenet Gateway (21:1/5)
  • From Ionen Wolkens@21:1/5 to All on Tue Jul 2 07:40:01 2024
    On Mon, Jul 01, 2024 at 11:36:01PM +0200, Ulrich Müller wrote:
    Apparently there is no reference to a .tmp_gas_check file or to a TOUT variable in Linux sources any more.

    Bug: https://bugs.gentoo.org/75034#c14
    Signed-off-by: Ulrich Müller <ulm@gentoo.org>
    ---
    eclass/linux-info.eclass | 6 ------
    1 file changed, 6 deletions(-)

    diff --git a/eclass/linux-info.eclass b/eclass/linux-info.eclass
    index 9449a6359d2a..90982445fdab 100644
    --- a/eclass/linux-info.eclass
    +++ b/eclass/linux-info.eclass
    @@ -170,12 +170,6 @@ KERNEL_DIR="${KERNEL_DIR:-${ROOT%/}/usr/src/linux}"
    inherit toolchain-funcs
    [[ ${EAPI} == 6 ]] && inherit eapi7-ver

    -# bug #75034
    -case ${ARCH} in
    - ppc) BUILD_FIXES="${BUILD_FIXES} TOUT=${T}/.tmp_gas_check";;
    - ppc64) BUILD_FIXES="${BUILD_FIXES} TOUT=${T}/.tmp_gas_check";;
    -esac

    On a side-note, it was further a no-op for linux-mod-r1 which opted to intentionally ignore BUILD_FIXES (variable is currently read by kernel-2
    and linux-mod-r0) and nobody complained.

    If wanted, technically all references of BUILD_FIXES could probably be
    removed from eclasses given (normally) nothing sets that variable beside
    that ppc workaround. It was also undocumented and more like a private
    variable.

    Albeit some ebuilds (like the pre-linux-mod-r1 lttng-modules ebuild)
    and users have wrongly used it, so it could break some spacebar heating.
    No real need to bother with linux-mod.eclass either way given it's due
    for eventual removal.
    --
    ionen

    -----BEGIN PGP SIGNATURE-----

    iQEzBAABCAAdFiEEx3SLh1HBoPy/yLVYskQGsLCsQzQFAmaDkYcACgkQskQGsLCs QzSwcggAxqDBxbrHV2EZtbvjWkwWuC0VBr7ySouDIWImv4dTPWKivCi329aZu3kb 4nRlT//A7QTwW58BquuXXIyiQp57zNoW2ERpjUwUlyABEk8R/ohBYnTtPyisDEVh Q2qLceuDYrWirURdX0ZfAZ6UlfJW2w9X0hAj0REzycbURiVZAkRul/qcfWhhVfd8 Ln7crhyKJaXJEiixr02jviYIXrudclROwjsD982l27d0bBmpSKaX9GJzR5GCHOjS LogtYDQRTEVdXGLM+UN5HBoqc6GP/iIGCeXabVBjIChgEY514AiSUuSkpE6jb4K/ OstizmAgVzpmNI0TJ6xg+WH072zFcg==
    =F0xg
    -----END PGP SIGNATURE-----

    --- SoupGate-Win32 v1.05
    * Origin: fsxNet Usenet Gateway (21:1/5)
  • From Ulrich Mueller@21:1/5 to All on Tue Jul 2 09:40:02 2024
    On Tue, 02 Jul 2024, Ionen Wolkens wrote:

    On a side-note, it was further a no-op for linux-mod-r1 which opted to intentionally ignore BUILD_FIXES (variable is currently read by kernel-2
    and linux-mod-r0) and nobody complained.

    If wanted, technically all references of BUILD_FIXES could probably be removed from eclasses given (normally) nothing sets that variable beside
    that ppc workaround. It was also undocumented and more like a private variable.

    Albeit some ebuilds (like the pre-linux-mod-r1 lttng-modules ebuild)
    and users have wrongly used it, so it could break some spacebar heating.
    No real need to bother with linux-mod.eclass either way given it's due
    for eventual removal.

    A follow-up patch removing the two remaining references to BUILD_FIXES
    (in getfilevar(), both in linux-info.eclass and in kernel-2.eclass)
    would be trivial. The variable was originally added by commit [1].

    Any other opinions on this?

    Ulrich

    [1] https://gitweb.gentoo.org/archive/repo/gentoo-2.git/commit/?id=c3d67d556962a79e055053f7cb88c67c46df293f

    -----BEGIN PGP SIGNATURE-----

    iQFDBAEBCAAtFiEEtDnZ1O9xIP68rzDbUYgzUIhBXi4FAmaDrnkPHHVsbUBnZW50 b28ub3JnAAoJEFGIM1CIQV4uPWkH/0SLrr+zcxeGAH+0WVLXn4zXGRTYV6dKCNDk lgsJKYo+u/fkdvFdFWfS/5dYH3AdtL4FuHlPnxqVbEc3/+nSNDLtTurdTvtplSZN npVms8BQsEVNn+C5DCJNyA9xfGbk38vwastG35I39s+f/caV3Mg/wZ+l0PLQKo0F 83mM+JVSGQeKOEOCpFmCBd7L+wKVCk6uDNT8l/XStdih6/ABM79cGCaAvtqpTg4T CM9+F6JvOKSA/AL/w907IEuFsGGZuhLREd1bh0mouWgJfeXG6Ojhe+SsANqzmh9B 4fvss8p9qOJKkDNevnQCZXPIce2OcQfxhevlIhcMiz6k6W/Afd8=
    =yEMy
    -----END PGP SIGNATURE-----

    --- SoupGate-Win32 v1.05
    * Origin: fsxNet Usenet Gateway (21:1/5)