1. Forum
  2. Usenet
  3. LINUX.GENTOO.DEV

  • [gentoo-dev] [PATCH] kernel-2.eclass: fix minor OBOBJCOPY -> OBJCOPY ty

    From Adrian Ratiu@21:1/5 to All on Wed Jan 5 17:10:02 2022
    Fixes:55f5c68c01e791c7339144aadc1f20802791551e
    Suggested-by: Manoj Gupta <manojgupta@chromium.org>
    Signed-off-by: Adrian Ratiu <adrian.ratiu@collabora.com>
    ---
    eclass/kernel-2.eclass | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/eclass/kernel-2.eclass b/eclass/kernel-2.eclass
    index 865c43d3153..d1784717e41 100644
    --- a/eclass/kernel-2.eclass
    +++ b/eclass/kernel-2.eclass
    @@ -692,7 +692,7 @@ env_setup_xmakeopts() {
    elif type -p ${CHOST}-ar >/dev/null; then
    xmakeopts="${xmakeopts} CROSS_COMPILE=${CHOST}-"
    fi
    - xmakeopts="${xmakeopts} HOSTCC=$(tc-getBUILD_CC) CC=$(tc-getCC) LD=$(tc-getLD) AR=$(tc-getAR) NM=$(tc-getNM) NM=$(tc-getNM) OBOBJCOPY=$(tc-getOBJCOPY) READELF=$(tc-getREADELF) STRIP=$(tc-getSTRIP)"
    + xmakeopts="${xmakeopts} HOSTCC=$(tc-getBUILD_CC) CC=$(tc-getCC) LD=$(tc-getLD) AR=$(tc-getAR) NM=$(tc-getNM) NM=$(tc-getNM) OBJCOPY=$(tc-getOBJCOPY) READELF=$(tc-getREADELF) STRIP=$(tc-getSTRIP)"
    export xmakeopts
    }

    --
    2.34.1

    --- SoupGate-Win32 v1.05
    * Origin: fsxNet Usenet Gateway (21:1/5)
  • From Emily Rowlands@21:1/5 to Adrian Ratiu on Wed Jan 5 20:00:01 2022
    Hi,

    I noticed that `NM=$(tc-getNM)` is duplicated in the changed line also,
    can you fix this at the same time?

    Thanks,
    Emily

    On 05/01/2022 15:59, Adrian Ratiu wrote:
    Fixes:55f5c68c01e791c7339144aadc1f20802791551e
    Suggested-by: Manoj Gupta <manojgupta@chromium.org>
    Signed-off-by: Adrian Ratiu <adrian.ratiu@collabora.com>
    ---
    eclass/kernel-2.eclass | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/eclass/kernel-2.eclass b/eclass/kernel-2.eclass
    index 865c43d3153..d1784717e41 100644
    --- a/eclass/kernel-2.eclass
    +++ b/eclass/kernel-2.eclass
    @@ -692,7 +692,7 @@ env_setup_xmakeopts() {
    elif type -p ${CHOST}-ar >/dev/null; then
    xmakeopts="${xmakeopts} CROSS_COMPILE=${CHOST}-"
    fi
    - xmakeopts="${xmakeopts} HOSTCC=$(tc-getBUILD_CC) CC=$(tc-getCC) LD=$(tc-getLD) AR=$(tc-getAR) NM=$(tc-getNM) NM=$(tc-getNM) OBOBJCOPY=$(tc-getOBJCOPY) READELF=$(tc-getREADELF) STRIP=$(tc-getSTRIP)"
    + xmakeopts="${xmakeopts} HOSTCC=$(tc-getBUILD_CC) CC=$(tc-getCC) LD=$(tc-getLD) AR=$(tc-getAR) NM=$(tc-getNM) NM=$(tc-getNM) OBJCOPY=$(tc-getOBJCOPY) READELF=$(tc-getREADELF) STRIP=$(tc-getSTRIP)"
    export xmakeopts
    }


    --- SoupGate-Win32 v1.05
    * Origin: fsxNet Usenet Gateway (21:1/5)
  • From Mike@21:1/5 to Emily Rowlands on Thu Jan 6 00:40:02 2022
    On 1/5/22 13:55, Emily Rowlands wrote:
    Hi,

    I noticed that `NM=$(tc-getNM)` is duplicated in the changed line also,
    can you fix this at the same time?

    Thanks,
    Emily

    On 05/01/2022 15:59, Adrian Ratiu wrote:
    Fixes:55f5c68c01e791c7339144aadc1f20802791551e
    Suggested-by: Manoj Gupta <manojgupta@chromium.org>
    Signed-off-by: Adrian Ratiu <adrian.ratiu@collabora.com>
    ---
    eclass/kernel-2.eclass | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/eclass/kernel-2.eclass b/eclass/kernel-2.eclass
    index 865c43d3153..d1784717e41 100644
    --- a/eclass/kernel-2.eclass
    +++ b/eclass/kernel-2.eclass
    @@ -692,7 +692,7 @@ env_setup_xmakeopts() {
    elif type -p ${CHOST}-ar >/dev/null; then
    xmakeopts="${xmakeopts} CROSS_COMPILE=${CHOST}-"
    fi
    - xmakeopts="${xmakeopts} HOSTCC=$(tc-getBUILD_CC) CC=$(tc-getCC) LD=$(tc-getLD) AR=$(tc-getAR) NM=$(tc-getNM) NM=$(tc-getNM) OBOBJCOPY=$(tc-getOBJCOPY) READELF=$(tc-getREADELF) STRIP=$(tc-getSTRIP)"
    + xmakeopts="${xmakeopts} HOSTCC=$(tc-getBUILD_CC) CC=$(tc-getCC) LD=$(tc-getLD) AR=$(tc-getAR) NM=$(tc-getNM) NM=$(tc-getNM) OBJCOPY=$(tc-getOBJCOPY) READELF=$(tc-getREADELF) STRIP=$(tc-getSTRIP)"
    export xmakeopts
    }



    Thanks for the report, duplicate removed

    --
    Mike Pagano
    Gentoo Developer - Kernel Project
    Gentoo Sources - Lead
    E-Mail : mpagano@gentoo.org
    GnuPG FP : 52CC A0B0 F631 0B17 0142 F83F 92A6 DBEC 81F2 B137
    Public Key : http://http://pgp.mit.edu/pks/lookup?search=0x92A6DBEC81F2B137&op=index

    --- SoupGate-Win32 v1.05
    * Origin: fsxNet Usenet Gateway (21:1/5)
  • From Georgy Yakovlev@21:1/5 to Adrian Ratiu on Fri Jan 7 03:30:01 2022
    merged with minor edit ( NM dupe removed in parent commit )
    thanks!

    On Wed, 2022-01-05 at 17:59 +0200, Adrian Ratiu wrote:
    Fixes:55f5c68c01e791c7339144aadc1f20802791551e
    Suggested-by: Manoj Gupta <manojgupta@chromium.org>
    Signed-off-by: Adrian Ratiu <adrian.ratiu@collabora.com>
    ---
     eclass/kernel-2.eclass | 2 +-
     1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/eclass/kernel-2.eclass b/eclass/kernel-2.eclass
    index 865c43d3153..d1784717e41 100644
    --- a/eclass/kernel-2.eclass
    +++ b/eclass/kernel-2.eclass
    @@ -692,7 +692,7 @@ env_setup_xmakeopts() {
            elif type -p ${CHOST}-ar >/dev/null; then                 xmakeopts="${xmakeopts} CROSS_COMPILE=${CHOST}-"
            fi
    -       xmakeopts="${xmakeopts} HOSTCC=$(tc-getBUILD_CC) CC=$(tc- getCC) LD=$(tc-getLD) AR=$(tc-getAR) NM=$(tc-getNM) NM=$(tc-getNM) OBOBJCOPY=$(tc-getOBJCOPY) READELF=$(tc-getREADELF) STRIP=$(tc-
    getSTRIP)"
    +       xmakeopts="${xmakeopts} HOSTCC=$(tc-getBUILD_CC) CC=$(tc- getCC) LD=$(tc-getLD) AR=$(tc-getAR) NM=$(tc-getNM) NM=$(tc-getNM) OBJCOPY=$(tc-getOBJCOPY) READELF=$(tc-getREADELF) STRIP=$(tc-
    getSTRIP)"
            export xmakeopts
     }
     

    --- SoupGate-Win32 v1.05
    * Origin: fsxNet Usenet Gateway (21:1/5)